8276687: Remove support for JDK 1.4.1 PerfData shared memory files #10687

iklam · 2022-10-13T04:06:27Z

We have code in jdk.internal.jvmstat for supporting an ancient version (JDK 1.4.1). There's currently no test case for this code, so it's likely to be further bit-rotten in the future. Let's remove it now.

If anyone wants to connect to JDK 1.4.1, they can use tools from JDK 19 or earlier.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8276687: Remove support for JDK 1.4.1 PerfData shared memory files

Reviewers

David Holmes (@dholmes-ora - Reviewer)
Kevin Walls (@kevinjwalls - Committer) ⚠️ Review applies to 2524f87d
Claes Redestad (@cl4es - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10687/head:pull/10687
$ git checkout pull/10687

Update a local copy of the PR:
$ git checkout pull/10687
$ git pull https://git.openjdk.org/jdk pull/10687/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10687

View PR using the GUI difftool:
$ git pr show -t 10687

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10687.diff

bridgekeeper · 2022-10-13T04:08:27Z

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-10-13T04:11:13Z

@iklam The following label will be automatically applied to this pull request:

serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-10-13T04:13:48Z

Webrevs

01: Full - Incremental (8e7b95fa)
00: Full (2524f87d)

dholmes-ora

Looks like a good cleanup. One suggestion/request below if you feel like it.

Thanks.

dholmes-ora · 2022-10-13T06:55:15Z

...internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/PerfDataFile.java

-                    return Integer.parseInt(name.substring(first + 1, last));
-                }
-            } catch (NumberFormatException e) { }
-        }
        throw new IllegalArgumentException("file name does not match pattern");


Pre-existing but it would be nice if this actually reported the file and the pattern.

Maybe "cannot convert 'filename' to VM id". (Or to pid.) We just parse it as an Integer now, so showing the problem filename would be nice. (Not sure if we would get this far trying a 1.4.1 attach, but if we did, it would help diagnose that.)

David and Kevin, thanks for the suggestions. I've update the error message. Does it look OK now?

openjdk · 2022-10-13T06:56:28Z

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276687: Remove support for JDK 1.4.1 PerfData shared memory files

Reviewed-by: dholmes, kevinw, redestad

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

fdb74ed: 8295301: Problem list TrayIcon tests that fail on Ubuntu 22.04
21407de: 8295173: (tz) Update Timezone Data to 2022e
f5f8df1: 8295295: CDS ArchivedEnumTest fails with StaticProperty::JAVA_LOCALE_USE_OLD_ISO_CODES
18dd9ee: 8295025: (bf) ByteBuffer "Access to binary data" section suggests putFloat is void
4224d45: 8295232: "java.locale.useOldISOCodes" property is read lazily
3b34387: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB
c7f6543: 8295223: JFR: At most one native periodic event thread at a time
7e4868d: 8294847: Fix calculation of G1 effective scanned cards prediction
2f60675: 8294997: Improve ECC math operations
94caecb: 8294906: Memory leak in PKCS11 NSS TLS server
... and 4 more: https://git.openjdk.org/jdk/compare/90fb9a085bbaa9d1928a1cec9f00098b80577721...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

kevinjwalls · 2022-10-13T10:49:09Z

Maybe the 3 classes in src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/v1_0/ are redundant...?
We parse a version number in AbstractPerfDataBuffer.createPerfDataBuffer() and create e.g. sun.jvmstat.perfdata.monitor.v2_0.PerfDataBuffer
I don't have evidence of exactly where version 2 starts (I know it was in jdk5, but maybe it was 1.4.2), so I'm not saying the removal should be done now.
Anyway, looks good.

iklam · 2022-10-13T19:36:31Z

Maybe the 3 classes in src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/v1_0/ are redundant...? We parse a version number in AbstractPerfDataBuffer.createPerfDataBuffer() and create e.g. sun.jvmstat.perfdata.monitor.v2_0.PerfDataBuffer I don't have evidence of exactly where version 2 starts (I know it was in jdk5, but maybe it was 1.4.2), so I'm not saying the removal should be done now. Anyway, looks good.

I have filed https://bugs.openjdk.org/browse/JDK-8295253 to remove the "kludge" code for supporting 1.4.1 in the monitor/v1_0/ code. Because of this kludge code, I suspect that v1_0 actually supports versions other than 1.4.1, so I am hesitant of removing the entire v1_0 directory. More investigation is needed.

cl4es

Nice cleanup!

kevinjwalls · 2022-10-13T20:42:34Z

Yes, that's good. OK so there is evidence that v1_0 perfdata was at least used for some 1.4.2, so yes no rush to remove the v1_0 classes, thanks.

dholmes-ora

Ok.

iklam · 2022-10-14T04:26:24Z

Thanks @kevinjwalls @cl4es @dholmes-ora for the review.
/integrate

openjdk · 2022-10-14T04:28:58Z

Going to push as commit 67046ae.
Since your change was applied there have been 16 commits pushed to the master branch:

b30d922: 8292876: Do not include the deprecated userinfo component of the URI in HTTP/2 headers
2b4830a: 8295017: Remove Windows specific workaround in JLI_Snprintf
fdb74ed: 8295301: Problem list TrayIcon tests that fail on Ubuntu 22.04
21407de: 8295173: (tz) Update Timezone Data to 2022e
f5f8df1: 8295295: CDS ArchivedEnumTest fails with StaticProperty::JAVA_LOCALE_USE_OLD_ISO_CODES
18dd9ee: 8295025: (bf) ByteBuffer "Access to binary data" section suggests putFloat is void
4224d45: 8295232: "java.locale.useOldISOCodes" property is read lazily
3b34387: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB
c7f6543: 8295223: JFR: At most one native periodic event thread at a time
7e4868d: 8294847: Fix calculation of G1 effective scanned cards prediction
... and 6 more: https://git.openjdk.org/jdk/compare/90fb9a085bbaa9d1928a1cec9f00098b80577721...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-10-14T04:29:12Z

@iklam Pushed as commit 67046ae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8276687: Remove support for JDK 1.4.1 PerfData shared memory files

2524f87

openjdk bot added the rfr Pull request is ready for review label Oct 13, 2022

openjdk bot added the serviceability serviceability-dev@openjdk.org label Oct 13, 2022

dholmes-ora approved these changes Oct 13, 2022

View changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 13, 2022

kevinjwalls approved these changes Oct 13, 2022

View changes

made exception message in PerfDataFile.getLocalVmId() more meaningful

8e7b95f

cl4es approved these changes Oct 13, 2022

View changes

dholmes-ora approved these changes Oct 13, 2022

View changes

openjdk bot added the integrated Pull request has been integrated label Oct 14, 2022

openjdk bot closed this Oct 14, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 14, 2022

iklam mentioned this pull request Nov 10, 2022

8295315: [REDO] 8276687 Remove support for JDK 1.4.1 PerfData shared memory files #11094

Closed

3 tasks

8276687: Remove support for JDK 1.4.1 PerfData shared memory files #10687

8276687: Remove support for JDK 1.4.1 PerfData shared memory files #10687

iklam commented Oct 13, 2022 •

edited by openjdk bot

bridgekeeper bot commented Oct 13, 2022

openjdk bot commented Oct 13, 2022

mlbridge bot commented Oct 13, 2022 •

edited

dholmes-ora left a comment

dholmes-ora Oct 13, 2022

kevinjwalls Oct 13, 2022

iklam Oct 13, 2022

openjdk bot commented Oct 13, 2022 •

edited

kevinjwalls commented Oct 13, 2022

iklam commented Oct 13, 2022

cl4es left a comment

kevinjwalls commented Oct 13, 2022

dholmes-ora left a comment

iklam commented Oct 14, 2022

openjdk bot commented Oct 14, 2022

openjdk bot commented Oct 14, 2022

8276687: Remove support for JDK 1.4.1 PerfData shared memory files #10687

8276687: Remove support for JDK 1.4.1 PerfData shared memory files #10687

Conversation

iklam commented Oct 13, 2022 • edited by openjdk bot

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Oct 13, 2022

openjdk bot commented Oct 13, 2022

mlbridge bot commented Oct 13, 2022 • edited

Webrevs

dholmes-ora left a comment

Choose a reason for hiding this comment

dholmes-ora Oct 13, 2022

Choose a reason for hiding this comment

kevinjwalls Oct 13, 2022

Choose a reason for hiding this comment

iklam Oct 13, 2022

Choose a reason for hiding this comment

openjdk bot commented Oct 13, 2022 • edited

kevinjwalls commented Oct 13, 2022

iklam commented Oct 13, 2022

cl4es left a comment

Choose a reason for hiding this comment

kevinjwalls commented Oct 13, 2022

dholmes-ora left a comment

Choose a reason for hiding this comment

iklam commented Oct 14, 2022

openjdk bot commented Oct 14, 2022

openjdk bot commented Oct 14, 2022

iklam commented Oct 13, 2022 •

edited by openjdk bot

mlbridge bot commented Oct 13, 2022 •

edited

openjdk bot commented Oct 13, 2022 •

edited