8295257: Remove implicit noreg temp register arguments in aarch64 MacroAssembler

[xmas92]

Remove implicit = noreg temporary register arguments for the three methods that still have them.

• load_heap_oop
• store_heap_oop
• load_heap_oop_not_null

Only load_heap_oop is used with the implicit = noreg arguments.
After JDK-8293351 the GCs only use explicitly passed in registers. This will also be the case for generational ZGC. Where it currently requires load_heap_oop to provide a second temporary register.

Testing: linux-aarch64, macosx-aarch64 tier 1-3

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8295257: Remove implicit noreg temp register arguments in aarch64 MacroAssembler

Reviewers

• Andrew Haley (@theRealAph - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10688/head:pull/10688
$ git checkout pull/10688

Update a local copy of the PR:
$ git checkout pull/10688
$ git pull https://git.openjdk.org/jdk pull/10688/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10688

View PR using the GUI difftool:
$ git pr show -t 10688

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10688.diff

[bridgekeeper]

👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@xmas92 The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4395b1e4)

[openjdk]

@xmas92 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295257: Remove implicit noreg temp register arguments in aarch64 MacroAssembler

Reviewed-by: aph, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 71 new commits pushed to the master branch:

• 71aa821: 8295176: some langtools test pollutes source tree
• bca7ab3: 8295412: support latest VS2022 MSC_VER in abstract_vm_version.cpp
• c33ca0c: 6229853: BasicTextAreaUI:create incompletely documents the possible returned View types
• 358ac07: 8294254: [macOS] javax/swing/plaf/aqua/CustomComboBoxFocusTest.java failure
• 490fcd0: 8293833: Error mixing types with -XX:+UseCMoveUnconditionally -XX:+UseVectorCmov
• 529cc48: 8295396: RISC-V: Cleanup useless CompressibleRegions
• 692cdab: 8295016: Make the arraycopy_epilogue signature consistent with its usage
• 21a825e: 8288387: GetLocalXXX/SetLocalXXX spec should require suspending target thread
• 8d751de: 8295231: Move all linking of native libraries to make
• f300ec8: 8294546: document where javac differs when invoked via launcher and ToolProvider
• ... and 61 more: https://git.openjdk.org/jdk/compare/cb62f1c5c0dd0d2a1570bace3c494a5c0c2b06b8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shqking]

I wonder if we can remove the implicit = noreg arguments for load_sized_value() and store_sized_value() as well?

[xmas92]

I wonder if we can remove the implicit = noreg arguments for load_sized_value() and store_sized_value() as well?

The argument can be removed all together. Register dst2 and Register src2 just seems to be leftovers from when this was created from the x86 MacroAssembler. They are only used for x86_32. I did not remove them in this patch as that change is more of a trivial code cleanup. (Removing unused arguments).

[shqking]

I wonder if we can remove the implicit = noreg arguments for load_sized_value() and store_sized_value() as well?

The argument can be removed all together. Register dst2 and Register src2 just seems to be leftovers from when this was created from the x86 MacroAssembler. They are only used for x86_32. I did not remove them in this patch as that change is more of a trivial code cleanup. (Removing unused arguments).

Okay. Thanks.
LGTM (I'm not a Reviewer).

[xmas92]

/integrate

[openjdk]

Going to push as commit a8c18eb.
Since your change was applied there have been 73 commits pushed to the master branch:

• 6553065: 8295273: Remove unused argument in [load/store]_sized_value on aarch64 and riscv
• b06f1b1: 8294594: Fix cast-function-type warnings in signal handling code
• 71aa821: 8295176: some langtools test pollutes source tree
• bca7ab3: 8295412: support latest VS2022 MSC_VER in abstract_vm_version.cpp
• c33ca0c: 6229853: BasicTextAreaUI:create incompletely documents the possible returned View types
• 358ac07: 8294254: [macOS] javax/swing/plaf/aqua/CustomComboBoxFocusTest.java failure
• 490fcd0: 8293833: Error mixing types with -XX:+UseCMoveUnconditionally -XX:+UseVectorCmov
• 529cc48: 8295396: RISC-V: Cleanup useless CompressibleRegions
• 692cdab: 8295016: Make the arraycopy_epilogue signature consistent with its usage
• 21a825e: 8288387: GetLocalXXX/SetLocalXXX spec should require suspending target thread
• ... and 63 more: https://git.openjdk.org/jdk/compare/cb62f1c5c0dd0d2a1570bace3c494a5c0c2b06b8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@xmas92 Pushed as commit a8c18eb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.