8255575: java.awt.color.ICC_ColorSpace is not thread-safe

[mrserb]

The ICC_ColorSpace class uses a couple of internal data caches that might be used w/o any synchronization by different threads.

The solution is to wrap the initialization of the cached data by the DLC. I have checked performance impact by the J2DBench and it seems no big difference before/after the fix.

BTW jdk16 in some cases x10 times faster than 8u and 11u. Probably we should backport something, will check that.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Testing

	Linux x64	Linux x86	Windows x64	macOS x64
Build	✔️ (5/5 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)
Test (tier1)	✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)

Issue

• JDK-8255575: java.awt.color.ICC_ColorSpace is not thread-safe

Reviewers

• Phil Race (@prrace - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1069/head:pull/1069
$ git checkout pull/1069

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mrserb The following labels will be automatically applied to this pull request:

• 2d
• awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e3eaaef)

[mrserb]

/label remove awt

[openjdk]

@mrserb
The awt label was successfully removed.

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255575: java.awt.color.ICC_ColorSpace is not thread-safe

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 82 new commits pushed to the master branch:

• f39a2c8: 8256015: Shenandoah: Add missing Shenandoah implementation in WB_isObjectInOldGen
• ed7526a: 8247872: Upgrade HarfBuzz to the latest 2.7.2
• 6a183fb: 8255562: delete UseRDPCForConstantTableBase
• c5462bb: 8255989: Remove explicitly unascribed authorship from Java source files
• 358f5d2: 6422025: ThemeReader.cpp can be updated for VC7
• a9dff94: 8254864: vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted001/TestDescription.java timed out
• 0b7fba7: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c
• f5d36e6: 8246741: NetworkInterface/UniqueMacAddressesTest: mac address uniqueness test failed
• 688b10b: 8255561: add tests to check binary compatibility rules for records
• 727a69f: 8255969: Improve java/io/BufferedInputStream/LargeCopyWithMark.java using jtreg tags
• ... and 72 more: https://git.openjdk.java.net/jdk/compare/9a367479279f46494d83356f34eddd29ab0045b1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mrserb]

/integrate

[openjdk]

@mrserb Since your change was applied there have been 83 commits pushed to the master branch:

• a53b12d: 8255722: Create a new test for rotated blit
• f39a2c8: 8256015: Shenandoah: Add missing Shenandoah implementation in WB_isObjectInOldGen
• ed7526a: 8247872: Upgrade HarfBuzz to the latest 2.7.2
• 6a183fb: 8255562: delete UseRDPCForConstantTableBase
• c5462bb: 8255989: Remove explicitly unascribed authorship from Java source files
• 358f5d2: 6422025: ThemeReader.cpp can be updated for VC7
• a9dff94: 8254864: vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted001/TestDescription.java timed out
• 0b7fba7: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c
• f5d36e6: 8246741: NetworkInterface/UniqueMacAddressesTest: mac address uniqueness test failed
• 688b10b: 8255561: add tests to check binary compatibility rules for records
• ... and 73 more: https://git.openjdk.java.net/jdk/compare/9a367479279f46494d83356f34eddd29ab0045b1...master

Your commit was automatically rebased without conflicts.

Pushed as commit 2cad836.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.