Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255575: java.awt.color.ICC_ColorSpace is not thread-safe #1069

Closed
wants to merge 4 commits into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Nov 5, 2020

The ICC_ColorSpace class uses a couple of internal data caches that might be used w/o any synchronization by different threads.

The solution is to wrap the initialization of the cached data by the DLC. I have checked performance impact by the J2DBench and it seems no big difference before/after the fix.

BTW jdk16 in some cases x10 times faster than 8u and 11u. Probably we should backport something, will check that.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8255575: java.awt.color.ICC_ColorSpace is not thread-safe

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1069/head:pull/1069
$ git checkout pull/1069

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 5, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 5, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2020

@mrserb The following labels will be automatically applied to this pull request:

  • 2d
  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added 2d awt labels Nov 5, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 5, 2020

Webrevs

@mrserb
Copy link
Member Author

@mrserb mrserb commented Nov 8, 2020

/label remove awt

@openjdk openjdk bot removed the awt label Nov 8, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 8, 2020

@mrserb
The awt label was successfully removed.

prrace
prrace approved these changes Nov 8, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 8, 2020

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255575: java.awt.color.ICC_ColorSpace is not thread-safe

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 82 new commits pushed to the master branch:

  • f39a2c8: 8256015: Shenandoah: Add missing Shenandoah implementation in WB_isObjectInOldGen
  • ed7526a: 8247872: Upgrade HarfBuzz to the latest 2.7.2
  • 6a183fb: 8255562: delete UseRDPCForConstantTableBase
  • c5462bb: 8255989: Remove explicitly unascribed authorship from Java source files
  • 358f5d2: 6422025: ThemeReader.cpp can be updated for VC7
  • a9dff94: 8254864: vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted001/TestDescription.java timed out
  • 0b7fba7: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c
  • f5d36e6: 8246741: NetworkInterface/UniqueMacAddressesTest: mac address uniqueness test failed
  • 688b10b: 8255561: add tests to check binary compatibility rules for records
  • 727a69f: 8255969: Improve java/io/BufferedInputStream/LargeCopyWithMark.java using jtreg tags
  • ... and 72 more: https://git.openjdk.java.net/jdk/compare/9a367479279f46494d83356f34eddd29ab0045b1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 8, 2020
@mrserb
Copy link
Member Author

@mrserb mrserb commented Nov 9, 2020

/integrate

@openjdk openjdk bot closed this Nov 9, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 9, 2020
@mrserb mrserb deleted the JDK-8255575 branch Nov 9, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 9, 2020

@mrserb Since your change was applied there have been 83 commits pushed to the master branch:

  • a53b12d: 8255722: Create a new test for rotated blit
  • f39a2c8: 8256015: Shenandoah: Add missing Shenandoah implementation in WB_isObjectInOldGen
  • ed7526a: 8247872: Upgrade HarfBuzz to the latest 2.7.2
  • 6a183fb: 8255562: delete UseRDPCForConstantTableBase
  • c5462bb: 8255989: Remove explicitly unascribed authorship from Java source files
  • 358f5d2: 6422025: ThemeReader.cpp can be updated for VC7
  • a9dff94: 8254864: vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted001/TestDescription.java timed out
  • 0b7fba7: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c
  • f5d36e6: 8246741: NetworkInterface/UniqueMacAddressesTest: mac address uniqueness test failed
  • 688b10b: 8255561: add tests to check binary compatibility rules for records
  • ... and 73 more: https://git.openjdk.java.net/jdk/compare/9a367479279f46494d83356f34eddd29ab0045b1...master

Your commit was automatically rebased without conflicts.

Pushed as commit 2cad836.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2d integrated
2 participants