8295258: Add BasicType argument to AccessInternal::decorator_fixup

[xmas92]

There are call sites of the access API that does not specify the INTERNAL_VALUE_IS_OOP decorator for some reference type access. Change it so that AccessInternal::decorator_fixup is able to add this decorator by passing in the BasicType of the access.

Testing: Oracle platforms tier 1-3 and GHA

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8295258: Add BasicType argument to AccessInternal::decorator_fixup

Reviewers

• Stefan Karlsson (@stefank - Reviewer)
• Erik Österlund (@fisk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10692/head:pull/10692
$ git checkout pull/10692

Update a local copy of the PR:
$ git checkout pull/10692
$ git pull https://git.openjdk.org/jdk pull/10692/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10692

View PR using the GUI difftool:
$ git pr show -t 10692

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10692.diff

[bridgekeeper]

👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@xmas92 The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c8334128)

[openjdk]

@xmas92 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295258: Add BasicType argument to AccessInternal::decorator_fixup

Reviewed-by: stefank, eosterlund

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 767 new commits pushed to the master branch:

• 4458de9: 8297172: Fix some issues of auto-vectorization of Long.bitCount/numberOfTrailingZeros/numberOfLeadingZeros()
• a613998: 8297689: Fix incorrect result of Short.reverseBytes() call in loops
• f8f4630: 8297963: Partially fix string expansion issues in UTIL_DEFUN_NAMED and related macros
• 2a243a3: 8267617: Certificate's IP x509 NameConstraints raises ArrayIndexOutOfBoundsException
• 923c746: 8298057: (fs) Remove PollingWatchService.POLLING_INIT_DELAY
• 0bd04a6: 8297951: C2: Create skeleton predicates for all If nodes in loop predication
• f5ad515: 8297247: Add GarbageCollectorMXBean for Remark and Cleanup pause time in G1
• e975418: 8298102: Remove DirtyCardToOopClosure::_last_explicit_min_done
• 04012c4: 8298111: Cleanups after UseMallocOnly removal
• ee9ba74: 8295184: Printing messages with a RecordComponentElement does not include position
• ... and 757 more: https://git.openjdk.org/jdk/compare/90fb9a085bbaa9d1928a1cec9f00098b80577721...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bridgekeeper]

@xmas92 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[fisk]

Looks good.

[xmas92]

/integrate

[openjdk]

Going to push as commit 085f96c.
Since your change was applied there have been 786 commits pushed to the master branch:

• 1c2a093: 8298147: Clang warns about pointless comparisons
• 8ea369a: 8298171: Missing newline in the example output of -Xlog:help
• acf96c6: 8290432: C2 compilation fails with assert(node->_last_del == _last) failed: must have deleted the edge just produced
• ce89673: 8297804: (tz) Update Timezone Data to 2022g
• 62baff5: 8298221: Problem list gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java on macosx-aarch64
• 16a5901: 8298214: ProblemList java/util/concurrent/forkjoin/AsyncShutdownNow.java
• b4da0ee: 8296507: GCM using more memory than necessary with in-place operations
• cd2182a: 8295724: VirtualMachineError: Out of space in CodeCache for method handle intrinsic
• 2cdc019: 8298178: Update to use jtreg 7.1.1
• 79d163d: 8293412: Remove unnecessary java.security.egd overrides
• ... and 776 more: https://git.openjdk.org/jdk/compare/90fb9a085bbaa9d1928a1cec9f00098b80577721...master

Your commit was automatically rebased without conflicts.

[openjdk]

@xmas92 Pushed as commit 085f96c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.