Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252995: Non-PCH builds broken by JDK-8250961 #107

Closed
wants to merge 1 commit into from

Conversation

kimbarrett
Copy link

@kimbarrett kimbarrett commented Sep 10, 2020

8252995: Non-PCH builds broken by JDK-8250961

Please review this trivial fix for no-PCH build failures, introduced by
JDK-8250961.

Only one file requires an additional #include. There are other files that
were modified by that change that probably should have had an include added,
on the "include what you use" theory. But in the interest of faster
turn-around to fix the build failure, I'm not dealing with any of those in
this change.

Testing:
local (linux-x64) no-pch build with shenandoah included
mach5 builds-tier1 (in progress)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/107/head:pull/107
$ git checkout pull/107

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 10, 2020

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 10, 2020

@kimbarrett The following label will be automatically applied to this pull request: hotspot-gc.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Sep 10, 2020
@kimbarrett kimbarrett changed the title add missing include 8252995: Non-PCH builds broken by JDK-8250961 Sep 10, 2020
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 10, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 10, 2020

Webrevs

Copy link
Contributor

@kstefanj kstefanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@openjdk
Copy link

openjdk bot commented Sep 10, 2020

@kimbarrett This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8252995: Non-PCH builds broken by JDK-8250961

Reviewed-by: sjohanss, stefank
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 6a005343b4f54586e48fdabfa988deb9d42eb4a6.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 10, 2020
Copy link
Member

@stefank stefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@kimbarrett
Copy link
Author

/integrate

@openjdk openjdk bot closed this Sep 10, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 10, 2020
@openjdk
Copy link

openjdk bot commented Sep 10, 2020

@kimbarrett Pushed as commit d236cf4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@adityamandaleeka
Copy link
Contributor

Thanks for fixing this @kimbarrett!

@kimbarrett kimbarrett deleted the JDK-8252995 branch September 15, 2020 07:15
robehn pushed a commit to robehn/jdk that referenced this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants