-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8252995: Non-PCH builds broken by JDK-8250961 #107
Conversation
👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into |
@kimbarrett The following label will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and trivial.
@kimbarrett This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements After integration, the commit message will be:
There are currently no new commits on the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and trivial.
/integrate |
@kimbarrett Pushed as commit d236cf4. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Thanks for fixing this @kimbarrett! |
8252995: Non-PCH builds broken by JDK-8250961
Please review this trivial fix for no-PCH build failures, introduced by
JDK-8250961.
Only one file requires an additional #include. There are other files that
were modified by that change that probably should have had an include added,
on the "include what you use" theory. But in the interest of faster
turn-around to fix the build failure, I'm not dealing with any of those in
this change.
Testing:
local (linux-x64) no-pch build with shenandoah included
mach5 builds-tier1 (in progress)
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/107/head:pull/107
$ git checkout pull/107