8295274: HelidonAppTest.java fails "assert(event->should_commit()) failed: invariant" from compiled frame"

[mgronlun]

Greetings,

In JDK-8287832, a change was made that removed the cached shouldCommit() state, under the premise that shouldCommit() is only called once. There are a few places that assert on shouldCommit(), that should have been removed as part of JDK-8287832.

This change complements these removals.

Testing: jdk_jfr

Thanks
Markus

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8295274: HelidonAppTest.java fails "assert(event->should_commit()) failed: invariant" from compiled frame"

Reviewers

• Erik Gahlin (@egahlin - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10700/head:pull/10700
$ git checkout pull/10700

Update a local copy of the PR:
$ git checkout pull/10700
$ git pull https://git.openjdk.org/jdk pull/10700/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10700

View PR using the GUI difftool:
$ git pr show -t 10700

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10700.diff

[bridgekeeper]

👋 Welcome back mgronlun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mgronlun The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (13acc953)

[mgronlun]

/label add hotspot-jfr

[openjdk]

@mgronlun
The hotspot-jfr label was successfully added.

[mgronlun]

/integrate

[openjdk]

@mgronlun This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295274: HelidonAppTest.java fails "assert(event->should_commit()) failed: invariant" from compiled frame"

Reviewed-by: egahlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

• f31c80d: 8294842: Pass actual pending cards to G1Policy::update_young_length_bounds during young gen revise
• 7133fc9: 7172359: HTML parser StackOverflowError on invalid HTML:
• tag inside an
• 3d75e88: 8295270: RISC-V: Clean up and refactoring for assembler functions
• be3b335: 8295026: Remove unused fields in StyleSheet
• 67046ae: 8276687: Remove support for JDK 1.4.1 PerfData shared memory files
• b30d922: 8292876: Do not include the deprecated userinfo component of the URI in HTTP/2 headers
• 2b4830a: 8295017: Remove Windows specific workaround in JLI_Snprintf
• fdb74ed: 8295301: Problem list TrayIcon tests that fail on Ubuntu 22.04
• 21407de: 8295173: (tz) Update Timezone Data to 2022e
• f5f8df1: 8295295: CDS ArchivedEnumTest fails with StaticProperty::JAVA_LOCALE_USE_OLD_ISO_CODES
• ... and 21 more: https://git.openjdk.org/jdk/compare/cb62f1c5c0dd0d2a1570bace3c494a5c0c2b06b8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

Going to push as commit 21e4f06.
Since your change was applied there have been 31 commits pushed to the master branch:

• f31c80d: 8294842: Pass actual pending cards to G1Policy::update_young_length_bounds during young gen revise
• 7133fc9: 7172359: HTML parser StackOverflowError on invalid HTML:
• tag inside an
• 3d75e88: 8295270: RISC-V: Clean up and refactoring for assembler functions
• be3b335: 8295026: Remove unused fields in StyleSheet
• 67046ae: 8276687: Remove support for JDK 1.4.1 PerfData shared memory files
• b30d922: 8292876: Do not include the deprecated userinfo component of the URI in HTTP/2 headers
• 2b4830a: 8295017: Remove Windows specific workaround in JLI_Snprintf
• fdb74ed: 8295301: Problem list TrayIcon tests that fail on Ubuntu 22.04
• 21407de: 8295173: (tz) Update Timezone Data to 2022e
• f5f8df1: 8295295: CDS ArchivedEnumTest fails with StaticProperty::JAVA_LOCALE_USE_OLD_ISO_CODES
• ... and 21 more: https://git.openjdk.org/jdk/compare/cb62f1c5c0dd0d2a1570bace3c494a5c0c2b06b8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mgronlun Pushed as commit 21e4f06.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.