Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295009: RISC-V: Interpreter intrinsify Thread.currentThread() #10709

Closed
wants to merge 1 commit into from

Conversation

yadongw
Copy link
Contributor

@yadongw yadongw commented Oct 14, 2022

Calling intrinsic version of Thread.currentThread() in interpreter is ~30% faster on the Unmatched board:
Before:
Benchmark Mode Cnt Score Error Units
MyBenchmark.testCurrentThread avgt 5 4665.765 ± 212.906 ns/op
After:
Benchmark Mode Cnt Score Error Units
MyBenchmark.testCurrentThread avgt 5 3381.415 ± 223.005 ns/op

Tier1 and jdk_loom have been tested on unmatched.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295009: RISC-V: Interpreter intrinsify Thread.currentThread()

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10709/head:pull/10709
$ git checkout pull/10709

Update a local copy of the PR:
$ git checkout pull/10709
$ git pull https://git.openjdk.org/jdk pull/10709/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10709

View PR using the GUI difftool:
$ git pr show -t 10709

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10709.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 14, 2022

👋 Welcome back yadongwang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 14, 2022
@openjdk
Copy link

openjdk bot commented Oct 14, 2022

@yadongw The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Oct 14, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 14, 2022

Webrevs

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Oct 14, 2022

@yadongw This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295009: RISC-V: Interpreter intrinsify Thread.currentThread()

Reviewed-by: fyang, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

  • e7d0ab2: 8295379: ProblemList java/lang/Float/Binary16Conversion.java in Xcomp mode on x64
  • 404e8de: 8294865: x86: Improve the code generation of MulVB and MulVL
  • 2087424: 8295370: Update java.io.ObjectStreamField to use Class.descriptorString
  • 8487c56: 8295294: Misc cleanups in runtime/InvocationTests
  • 0043d58: 8293531: C2: some vectorapi tests fail assert "Not monotonic" with flag -XX:TypeProfileLevel=222
  • 2e2a51e: 8295267: Improve G1 scan to merge ratio calculation
  • dfcd9d5: 8295320: [BACKOUT] 8276687 Remove support for JDK 1.4.1 PerfData shared memory files
  • 2da079c: 8294426: Two fingers tap generates wrong mouse modifiers on M2 MacBooks
  • 449b52f: 8295158: G1: Increase card-based cost sample reporting threshold
  • 312985e: 8295156: G1: Improve constant other time calculation
  • ... and 12 more: https://git.openjdk.org/jdk/compare/2b4830a3959496372719270614a58737cf4deb2f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 14, 2022
Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@yadongw
Copy link
Contributor Author

yadongw commented Oct 16, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 16, 2022
@openjdk
Copy link

openjdk bot commented Oct 16, 2022

@yadongw
Your change (at version 84a0ad8) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 16, 2022

Going to push as commit d3781ac.
Since your change was applied there have been 22 commits pushed to the master branch:

  • e7d0ab2: 8295379: ProblemList java/lang/Float/Binary16Conversion.java in Xcomp mode on x64
  • 404e8de: 8294865: x86: Improve the code generation of MulVB and MulVL
  • 2087424: 8295370: Update java.io.ObjectStreamField to use Class.descriptorString
  • 8487c56: 8295294: Misc cleanups in runtime/InvocationTests
  • 0043d58: 8293531: C2: some vectorapi tests fail assert "Not monotonic" with flag -XX:TypeProfileLevel=222
  • 2e2a51e: 8295267: Improve G1 scan to merge ratio calculation
  • dfcd9d5: 8295320: [BACKOUT] 8276687 Remove support for JDK 1.4.1 PerfData shared memory files
  • 2da079c: 8294426: Two fingers tap generates wrong mouse modifiers on M2 MacBooks
  • 449b52f: 8295158: G1: Increase card-based cost sample reporting threshold
  • 312985e: 8295156: G1: Improve constant other time calculation
  • ... and 12 more: https://git.openjdk.org/jdk/compare/2b4830a3959496372719270614a58737cf4deb2f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 16, 2022
@openjdk openjdk bot closed this Oct 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 16, 2022
@openjdk
Copy link

openjdk bot commented Oct 16, 2022

@RealFYang @yadongw Pushed as commit d3781ac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants