Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295396: RISC-V: Cleanup useless CompressibleRegions #10722

Closed

Conversation

zhengxiaolinX
Copy link
Contributor

@zhengxiaolinX zhengxiaolinX commented Oct 17, 2022

Cleanup no longer used old code introduced in the riscv-port repo after #10643, in which we have marked out all incompressible places so all other generated instructions could be safely compressed if compressible. Hence the old CompressibleRegions are useless and need a cleanup.

After this patch there are only two places using CompressibleRegions: MachNopNode::emit() and MacroAssembler::align(). These CompressibleRegions transforming the nops used for alignment purposes cannot be removed and the nops should be kept as 2-byte when RVC is enabled, for that we are at a 2-byte boundary and want to do align(4) with 4-byte nops would be impossible. So under RVC the nops for alignment purposes must be 2-byte ones. Others CompressibleRegions are useless now.

Has passed hotspot tier1~4 together with other patches; another tier1 is running.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295396: RISC-V: Cleanup useless CompressibleRegions

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10722/head:pull/10722
$ git checkout pull/10722

Update a local copy of the PR:
$ git checkout pull/10722
$ git pull https://git.openjdk.org/jdk pull/10722/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10722

View PR using the GUI difftool:
$ git pr show -t 10722

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10722.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 17, 2022

👋 Welcome back xlinzheng! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 17, 2022
@openjdk
Copy link

openjdk bot commented Oct 17, 2022

@zhengxiaolinX The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Oct 17, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 17, 2022

Webrevs

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Oct 17, 2022

@zhengxiaolinX This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295396: RISC-V: Cleanup useless CompressibleRegions

Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • 692cdab: 8295016: Make the arraycopy_epilogue signature consistent with its usage
  • 21a825e: 8288387: GetLocalXXX/SetLocalXXX spec should require suspending target thread
  • 8d751de: 8295231: Move all linking of native libraries to make
  • f300ec8: 8294546: document where javac differs when invoked via launcher and ToolProvider
  • b269c51: 8295395: Linux Alpha Zero builds fail after JDK-8292591
  • ae60599: 8295023: Interpreter(AArch64): Implement -XX:+PrintBytecodeHistogram and -XX:+PrintBytecodePairHistogram options
  • 4d37ef2: 8295262: Build binutils out of source tree
  • 0919a3a: 8294186: AArch64: VectorMaskToLong failed on SVE2 machine with -XX:UseSVE=1
  • ec2981b: 8293711: Factor out size parsing functions from arguments.cpp
  • 5d273b9: 8295278: Add parallel class loading tests
  • ... and 4 more: https://git.openjdk.org/jdk/compare/b3bb3e6ed89f3abcaae584fcbe75688141e886cb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 17, 2022
@zhengxiaolinX
Copy link
Contributor Author

zhengxiaolinX commented Oct 18, 2022

Thanks for the fast review! Trivial as this one looks, going to merge it.

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 18, 2022
@openjdk
Copy link

openjdk bot commented Oct 18, 2022

@zhengxiaolinX
Your change (at version 9778ae5) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 18, 2022

Going to push as commit 529cc48.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 692cdab: 8295016: Make the arraycopy_epilogue signature consistent with its usage
  • 21a825e: 8288387: GetLocalXXX/SetLocalXXX spec should require suspending target thread
  • 8d751de: 8295231: Move all linking of native libraries to make
  • f300ec8: 8294546: document where javac differs when invoked via launcher and ToolProvider
  • b269c51: 8295395: Linux Alpha Zero builds fail after JDK-8292591
  • ae60599: 8295023: Interpreter(AArch64): Implement -XX:+PrintBytecodeHistogram and -XX:+PrintBytecodePairHistogram options
  • 4d37ef2: 8295262: Build binutils out of source tree
  • 0919a3a: 8294186: AArch64: VectorMaskToLong failed on SVE2 machine with -XX:UseSVE=1
  • ec2981b: 8293711: Factor out size parsing functions from arguments.cpp
  • 5d273b9: 8295278: Add parallel class loading tests
  • ... and 4 more: https://git.openjdk.org/jdk/compare/b3bb3e6ed89f3abcaae584fcbe75688141e886cb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 18, 2022
@openjdk openjdk bot closed this Oct 18, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 18, 2022
@openjdk
Copy link

openjdk bot commented Oct 18, 2022

@RealFYang @zhengxiaolinX Pushed as commit 529cc48.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
2 participants