8295401: Error recovery in module-info.java could be improved

[lahodaj]

Consider an erroneous module-info.java like:

module m {
    provides javax.util.;
}

When javac parses this code, the resulting AST will not contain the (incomplete) directive for provides. This is different from the other directives, which are included, and complicates developing features, like code completion, over the AST.

The proposal is to simply include the incomplete provides directive in the list of directives.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8295401: Error recovery in module-info.java could be improved

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10728/head:pull/10728
$ git checkout pull/10728

Update a local copy of the PR:
$ git checkout pull/10728
$ git pull https://git.openjdk.org/jdk pull/10728/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10728

View PR using the GUI difftool:
$ git pr show -t 10728

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10728.diff

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lahodaj The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3ba26dbc)

[bridgekeeper]

@lahodaj This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[vicente-romero-oracle]

looks good

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295401: Error recovery in module-info.java could be improved

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 566 new commits pushed to the master branch:

• a249a52: 8296754: AutoCreateSharedArchive in JDK 20 is not compatible with JDK 19
• 405b188: 8297570: jdk/jfr/threading/TestDeepVirtualStackTrace.java fails with -XX:-UseTLAB
• ba0a252: 8297717: Remove jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java from ProblemList
• c05dc80: 8297660: x86: Redundant test+jump in C1 allocateArray
• eff4c03: 8297343: TestStress*.java fail with "got different traces for the same seed"
• 6a856bc: 8297499: Parallel: Missing iteration over klass when marking objArrays/objArrayOops during Full GC
• b80f5af: 8297309: Memory leak in ShenandoahFullGC
• 81eb5fb: 8297534: Specify the size of MEMFLAGS
• 012dafe: 8297082: Remove sun/tools/jhsdb/BasicLauncherTest.java from problem list
• 43d1173: 8286302: Port JEP 425 to PPC64
• ... and 556 more: https://git.openjdk.org/jdk/compare/cf07eaeb9291da725181832b8bb1dc54957ba886...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lahodaj]

/integrate

[openjdk]

Going to push as commit b52611b.
Since your change was applied there have been 609 commits pushed to the master branch:

• 9e80cf9: 8296390: Incremental build failed with a NPE
• b3501fd: 8297600: Check current thread in selected JRT_LEAF methods
• f05bfb1: 8297515: serialVersionUID fields are not annotated with @serial
• 22f5d01: 8252584: HotSpot Style Guide should permit alignas
• 8ffed34: 8297681: Unnecessary color conversion during 4BYTE_ABGR_PRE to INT_ARGB_PRE blit
• abe532a: 8296924: C2: assert(is_valid_AArch64_address(dest.target())) failed: bad address
• 5dcaf6c: 8297749: Remove duplicate space in the ProtocolException message being thrown from HttpURLConnection
• c7a679f: 8297290: Use int indices to reference CDS archived primitive mirrors
• 37f613b: 8297676: DataBuffer.TYPE_SHORT/TYPE_FLOAT/TYPE_DOUBLE are not placeholders
• 87f00f4: 8296878: Document Filter attached to JPasswordField and setText("") is not cleared instead inserted characters replaced with unicode null characters
• ... and 599 more: https://git.openjdk.org/jdk/compare/cf07eaeb9291da725181832b8bb1dc54957ba886...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lahodaj Pushed as commit b52611b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.