Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284614: on macOS "spindump" should be run from failure_handler as root #10730

Closed
wants to merge 1 commit into from

Conversation

lmesnik
Copy link
Member

@lmesnik lmesnik commented Oct 17, 2022

The fix is contributed by @plummercj actually.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8284614: on macOS "spindump" should be run from failure_handler as root

Reviewers

Contributors

  • Chris Plummer <cjplummer@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10730/head:pull/10730
$ git checkout pull/10730

Update a local copy of the PR:
$ git checkout pull/10730
$ git pull https://git.openjdk.org/jdk pull/10730/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10730

View PR using the GUI difftool:
$ git pr show -t 10730

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10730.diff

@lmesnik
Copy link
Member Author

lmesnik commented Oct 17, 2022

/contributor plummercj

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 17, 2022

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@lmesnik
Copy link
Member Author

lmesnik commented Oct 17, 2022

/contributor add plummercj

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 17, 2022
@openjdk
Copy link

openjdk bot commented Oct 17, 2022

@lmesnik Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

@openjdk
Copy link

openjdk bot commented Oct 17, 2022

@lmesnik plummercj was not found in the census.

Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

@openjdk
Copy link

openjdk bot commented Oct 17, 2022

@lmesnik The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Oct 17, 2022
@lmesnik
Copy link
Member Author

lmesnik commented Oct 17, 2022

/contributor add @plummercj

@lmesnik
Copy link
Member Author

lmesnik commented Oct 17, 2022

/label add hotspot

@lmesnik
Copy link
Member Author

lmesnik commented Oct 17, 2022

/label remove core-libs

@openjdk
Copy link

openjdk bot commented Oct 17, 2022

@lmesnik
Contributor Chris Plummer <cjplummer@openjdk.org> successfully added.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Oct 17, 2022
@openjdk
Copy link

openjdk bot commented Oct 17, 2022

@lmesnik
The hotspot label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Oct 17, 2022

Webrevs

@openjdk openjdk bot removed the core-libs core-libs-dev@openjdk.org label Oct 17, 2022
@openjdk
Copy link

openjdk bot commented Oct 17, 2022

@lmesnik
The core-libs label was successfully removed.

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up.

@openjdk
Copy link

openjdk bot commented Oct 18, 2022

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284614: on macOS "spindump" should be run from failure_handler as root

Co-authored-by: Chris Plummer <cjplummer@openjdk.org>
Reviewed-by: dnsimon, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

  • 2a799e5: 8285306: Fix typos in java.desktop
  • d1f7945: 6924219: (fc spec) FileChannel.write(ByteBuffer, position) behavior when file opened for append not specified
  • 5dbd495: 8295457: Make the signatures of write barrier methods consistent
  • 7b2e83b: 8295469: S390X: Optimized builds are broken
  • 63867c4: 8295433: EpsilonHeap doesn't need to override post_initialize()
  • e7375f9: 8295468: RISC-V: Minimal builds are broken
  • bd41428: 8293590: Some syntax checks performed by URL.openConnection() could be performed earlier, at URL construction
  • 78fed9d: 7175397: The divider color is not changed to green when dragging for Nimbus LaF.
  • 8c40b7d: 8292177: InitialSecurityProperty JFR event
  • e7a964b: 8295268: Optimized builds are broken due to incorrect assert_is_rfp shortcuts
  • ... and 16 more: https://git.openjdk.org/jdk/compare/ae60599e2ba75d80c3b4279903137b2c549f8066...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 18, 2022
@dcubed-ojdk
Copy link
Member

For folks that run testing on their personal Mac machines will want to update:

$ cat /etc/sudoers.d/sudoers 
<user> ALL=(ALL) NOPASSWD: /sbin/dmesg, /usr/sbin/spindump

Where "" is replaced by your local username, e.g. "dcubed".

@dcubed-ojdk
Copy link
Member

@tbell29552 - There may be a need to update Ansible playbooks for
the macOS machines in Mach5.

@lmesnik
Copy link
Member Author

lmesnik commented Oct 18, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 18, 2022

Going to push as commit 0233ba7.
Since your change was applied there have been 26 commits pushed to the master branch:

  • 2a799e5: 8285306: Fix typos in java.desktop
  • d1f7945: 6924219: (fc spec) FileChannel.write(ByteBuffer, position) behavior when file opened for append not specified
  • 5dbd495: 8295457: Make the signatures of write barrier methods consistent
  • 7b2e83b: 8295469: S390X: Optimized builds are broken
  • 63867c4: 8295433: EpsilonHeap doesn't need to override post_initialize()
  • e7375f9: 8295468: RISC-V: Minimal builds are broken
  • bd41428: 8293590: Some syntax checks performed by URL.openConnection() could be performed earlier, at URL construction
  • 78fed9d: 7175397: The divider color is not changed to green when dragging for Nimbus LaF.
  • 8c40b7d: 8292177: InitialSecurityProperty JFR event
  • e7a964b: 8295268: Optimized builds are broken due to incorrect assert_is_rfp shortcuts
  • ... and 16 more: https://git.openjdk.org/jdk/compare/ae60599e2ba75d80c3b4279903137b2c549f8066...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 18, 2022
@openjdk openjdk bot closed this Oct 18, 2022
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Oct 18, 2022
@openjdk openjdk bot removed the rfr Pull request is ready for review label Oct 18, 2022
@openjdk
Copy link

openjdk bot commented Oct 18, 2022

@lmesnik Pushed as commit 0233ba7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lmesnik lmesnik deleted the 8284614 branch June 5, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants