Skip to content

Conversation

@mcpowers
Copy link
Contributor

@mcpowers mcpowers commented Oct 17, 2022

https://bugs.openjdk.org/browse/JDK-8293681


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10732/head:pull/10732
$ git checkout pull/10732

Update a local copy of the PR:
$ git checkout pull/10732
$ git pull https://git.openjdk.org/jdk pull/10732/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10732

View PR using the GUI difftool:
$ git pr show -t 10732

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10732.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 17, 2022

👋 Welcome back mpowers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 17, 2022
@openjdk
Copy link

openjdk bot commented Oct 17, 2022

@mcpowers The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Oct 17, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 17, 2022

Webrevs

Copy link
Contributor

@valeriepeng valeriepeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks~

@openjdk
Copy link

openjdk bot commented Oct 18, 2022

@mcpowers This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293681: ResponseAPDU getData() method javadoc

Reviewed-by: valeriep

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 137 new commits pushed to the master branch:

  • 8d4c077: 8295302: Do not use ArrayList when LambdaForm has a single ClassData
  • 017e798: 8293939: Move continuation_enter_setup and friends
  • f872467: 8255746: Make PrintCompilation available on a per method level
  • 388a56e: 8294467: Fix sequence-point warnings in Hotspot
  • ceb5b08: 8294468: Fix char-subscripts warnings in Hotspot
  • 7b1c676: 8295662: jdk/incubator/vector tests fail "assert(VM_Version::supports_avx512vlbw()) failed"
  • 5eaf568: 8295668: validate-source failure after JDK-8290011
  • e238920: 8295372: CompactNumberFormat handling of number one with decimal part
  • a5f6e31: 8295456: (ch) sun.nio.ch.Util::checkBufferPositionAligned gives misleading/incorrect error
  • e27bea0: 8290011: IGV: Remove dead code and cleanup
  • ... and 127 more: https://git.openjdk.org/jdk/compare/07946aa49c97c93bd11675a9b0b90d07c83f2a94...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@valeriepeng) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 18, 2022
@mcpowers
Copy link
Contributor Author

@valeriepeng thanks for the review!

@mcpowers
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 19, 2022
@openjdk
Copy link

openjdk bot commented Oct 19, 2022

@mcpowers
Your change (at version 40bec85) is now ready to be sponsored by a Committer.

@wangweij
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 14, 2022

Going to push as commit e269dc0.
Since your change was applied there have been 413 commits pushed to the master branch:

  • 8c472e4: 8294217: Assertion failure: parsing found no loops but there are some
  • 0fe2bf5: 8296805: ctw build is broken
  • e1d298c: 8296741: Illegal X400Address and EDIPartyName should not be created
  • b0edfc1: 8164464: Consistent failure of java/awt/dnd/MissingEventsOnModalDialog/MissingEventsOnModalDialogTest.java
  • 9c39932: 8294899: Process.waitFor() throws IllegalThreadStateException when a process on Windows returns an exit code of 259
  • 3f401b3: 8296670: G1: Remove unused G1GCPhaseTimes::record_preserve_cm_referents_time_ms
  • 68301cd: 8296665: IGV: Show dialog with stack trace for exceptions
  • 277f0c2: 8296821: compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/NativeCallTest.java fails after JDK-8262901
  • 34d10f1: 8296243: [IR Framework] Fix issues with IRNode.ALLOC* regexes
  • 8eb90e2: 8296797: java/nio/channels/vthread/BlockingChannelOps.testSocketChannelWriteAsyncClose failed with ClosedChannelException
  • ... and 403 more: https://git.openjdk.org/jdk/compare/07946aa49c97c93bd11675a9b0b90d07c83f2a94...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 14, 2022
@openjdk openjdk bot closed this Nov 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 14, 2022
@openjdk
Copy link

openjdk bot commented Nov 14, 2022

@wangweij @mcpowers Pushed as commit e269dc0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mcpowers mcpowers deleted the JDK-8293681 branch December 16, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants