Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295429: Update harfbuzz md file #10735

Closed
wants to merge 2 commits into from

Conversation

DamonGuy
Copy link
Contributor

@DamonGuy DamonGuy commented Oct 18, 2022

Update the harfbuzz md file with the newly generated md file. Matched format of previous license and organized copyright lines.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10735/head:pull/10735
$ git checkout pull/10735

Update a local copy of the PR:
$ git checkout pull/10735
$ git pull https://git.openjdk.org/jdk pull/10735/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10735

View PR using the GUI difftool:
$ git pr show -t 10735

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10735.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 18, 2022

👋 Welcome back dnguyen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@DamonGuy DamonGuy changed the title 8295429: Update md file 8295429: Update harfbuzz md file Oct 18, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 18, 2022
@openjdk
Copy link

openjdk bot commented Oct 18, 2022

@DamonGuy The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Oct 18, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 18, 2022

Webrevs

@DamonGuy DamonGuy marked this pull request as draft October 18, 2022 15:58
@openjdk openjdk bot removed the rfr Pull request is ready for review label Oct 18, 2022
@DamonGuy DamonGuy marked this pull request as ready for review October 18, 2022 21:50
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 18, 2022
@openjdk
Copy link

openjdk bot commented Oct 18, 2022

@DamonGuy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295429: Update harfbuzz md file

Reviewed-by: azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@azvegint) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 18, 2022
@DamonGuy
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 18, 2022
@openjdk
Copy link

openjdk bot commented Oct 18, 2022

@DamonGuy
Your change (at version 5361656) is now ready to be sponsored by a Committer.

@azvegint
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 19, 2022

Going to push as commit 21aeb9e.
Since your change was applied there have been 44 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 19, 2022
@openjdk openjdk bot closed this Oct 19, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 19, 2022
@openjdk
Copy link

openjdk bot commented Oct 19, 2022

@azvegint @DamonGuy Pushed as commit 21aeb9e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants