Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255937: Better cleanup for test/jdk/javax/imageio/stream/StreamFlush.java #1074

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Nov 5, 2020

The test leaves two temporary files due to unclosed file streams.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8255937: Better cleanup for test/jdk/javax/imageio/stream/StreamFlush.java

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1074/head:pull/1074
$ git checkout pull/1074

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 5, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2020

@mrserb The following label will be automatically applied to this pull request:

  • 2d

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the 2d label Nov 5, 2020
@mrserb mrserb marked this pull request as ready for review Nov 5, 2020
@openjdk openjdk bot added the rfr label Nov 5, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 5, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2020

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255937: Better cleanup for test/jdk/javax/imageio/stream/StreamFlush.java

Reviewed-by: jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 2b78a43: 8255584: HttpPrincipal::getName returns incorrect name
  • a6ce6a5: 8252103: Parallel heap inspection for ParallelScavengeHeap
  • cdef186: 8232856: jshell crashes when pressing up arrow after /!
  • 700447f: 8255909: Remove unused delayed_value methods

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 5, 2020
@mrserb
Copy link
Member Author

@mrserb mrserb commented Nov 5, 2020

/integrate

@openjdk openjdk bot closed this Nov 5, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 5, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2020

@mrserb Since your change was applied there have been 5 commits pushed to the master branch:

  • b65ff60: 8255226: (tz) Upgrade time-zone data to tzdata2020d
  • 2b78a43: 8255584: HttpPrincipal::getName returns incorrect name
  • a6ce6a5: 8252103: Parallel heap inspection for ParallelScavengeHeap
  • cdef186: 8232856: jshell crashes when pressing up arrow after /!
  • 700447f: 8255909: Remove unused delayed_value methods

Your commit was automatically rebased without conflicts.

Pushed as commit d3c43c2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8255937 branch Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2d integrated
2 participants