8295468: RISC-V: Minimal builds are broken

[shipilev]

Attempting to build RISC-V "minimal" variant fails with:

* For target hotspot_variant-minimal_libjvm_objs_macroAssembler_riscv.o:
In file included from /home/shade/trunks/jdk/src/hotspot/share/utilities/globalDefinitions.hpp:29,
                 from /home/shade/trunks/jdk/src/hotspot/share/memory/allocation.hpp:29,
                 from /home/shade/trunks/jdk/src/hotspot/share/memory/arena.hpp:28,
                 from /home/shade/trunks/jdk/src/hotspot/share/runtime/handles.hpp:28,
                 from /home/shade/trunks/jdk/src/hotspot/share/code/oopRecorder.hpp:28,
                 from /home/shade/trunks/jdk/src/hotspot/share/asm/codeBuffer.hpp:28,
                 from /home/shade/trunks/jdk/src/hotspot/share/asm/assembler.hpp:28,
                 from /home/shade/trunks/jdk/src/hotspot/cpu/riscv/macroAssembler_riscv.cpp:28:
/home/shade/trunks/jdk/src/hotspot/cpu/riscv/macroAssembler_riscv.cpp: In member function 'void MacroAssembler::movoop(Register, jobject)':
/home/shade/trunks/jdk/src/hotspot/cpu/riscv/macroAssembler_riscv.cpp:1966:30: error: invalid use of incomplete type 'class CollectedHeap'
 1966 | assert(Universe::heap()->is_in(JNIHandles::resolve(obj)), "should be real oop");
      | ^~

Additional testing:

• Linux RISC-V minimal builds {release, fastdebug, slowdebug, optimized}

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8295468: RISC-V: Minimal builds are broken

Reviewers

• Thomas Stuefe (@tstuefe - Reviewer)
• Ludovic Henry (@luhenry - Author)
• Fei Yang (@RealFYang - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10742/head:pull/10742
$ git checkout pull/10742

Update a local copy of the PR:
$ git checkout pull/10742
$ git pull https://git.openjdk.org/jdk pull/10742/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10742

View PR using the GUI difftool:
$ git pr show -t 10742

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10742.diff

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (6a81c50f)

[tstuefe]

+1 trivial

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295468: RISC-V: Minimal builds are broken

Reviewed-by: stuefe, luhenry, fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• bd41428: 8293590: Some syntax checks performed by URL.openConnection() could be performed earlier, at URL construction
• 78fed9d: 7175397: The divider color is not changed to green when dragging for Nimbus LaF.
• 8c40b7d: 8292177: InitialSecurityProperty JFR event

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RealFYang]

I see this problem only menifest itself in a minimal debug build. I just realized that I am always doing minimal release build and that's why I missed it. Thanks.

[shipilev]

Thanks!

/integrate

[openjdk]

Going to push as commit e7375f9.
Since your change was applied there have been 3 commits pushed to the master branch:

• bd41428: 8293590: Some syntax checks performed by URL.openConnection() could be performed earlier, at URL construction
• 78fed9d: 7175397: The divider color is not changed to green when dragging for Nimbus LaF.
• 8c40b7d: 8292177: InitialSecurityProperty JFR event

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit e7375f9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.