Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295456: (ch) sun.nio.ch.Util::checkBufferPositionAligned gives misleading/incorrect error #10753

Closed

Conversation

bplb
Copy link
Member

@bplb bplb commented Oct 18, 2022

Improve IOException message in sun.nio.ch.Util::checkBufferPositionAligned.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295456: (ch) sun.nio.ch.Util::checkBufferPositionAligned gives misleading/incorrect error

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10753/head:pull/10753
$ git checkout pull/10753

Update a local copy of the PR:
$ git checkout pull/10753
$ git pull https://git.openjdk.org/jdk pull/10753/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10753

View PR using the GUI difftool:
$ git pr show -t 10753

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10753.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 18, 2022

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 18, 2022
@openjdk
Copy link

openjdk bot commented Oct 18, 2022

@bplb The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Oct 18, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 18, 2022

Webrevs

@bplb bplb force-pushed the Util-checkBufferPositionAligned-8295456 branch from b073ad6 to a09caf9 Compare October 18, 2022 23:46
@openjdk-notifier
Copy link

@bplb Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

@openjdk
Copy link

openjdk bot commented Oct 19, 2022

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295456: (ch) sun.nio.ch.Util::checkBufferPositionAligned gives misleading/incorrect error

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 19, 2022
@bplb
Copy link
Member Author

bplb commented Oct 19, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 19, 2022

Going to push as commit a5f6e31.
Since your change was applied there have been 23 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 19, 2022
@openjdk openjdk bot closed this Oct 19, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 19, 2022
@openjdk
Copy link

openjdk bot commented Oct 19, 2022

@bplb Pushed as commit a5f6e31.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the Util-checkBufferPositionAligned-8295456 branch October 19, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated nio nio-dev@openjdk.org
2 participants