8291914: generated constructors are considered compact when they shouldn't

[vicente-romero-oracle]

javac is considering all record generated constructors as compact constructors. According to the spec compact constructors should be declared explicitly. This constructor is compact:

record R1(int i) {
    R1 {}
}

here there is no explicit constructor so the compiler is providing one but it shouldn't be considered a compact constructor:

record R2(int i) {}

this PR is fixing the current compiler bug so that for declarations like record R2 the compiler generated constructor is not considered a compact one.

TIA

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8291914: generated constructors are considered compact when they shouldn't

Reviewers

• Joe Darcy (@jddarcy - Reviewer)
• Jan Lahoda (@lahodaj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10756/head:pull/10756
$ git checkout pull/10756

Update a local copy of the PR:
$ git checkout pull/10756
$ git pull https://git.openjdk.org/jdk pull/10756/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10756

View PR using the GUI difftool:
$ git pr show -t 10756

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10756.diff

[bridgekeeper]

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vicente-romero-oracle The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (768beccc)

[jddarcy]

Test changes look good.

[openjdk]

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291914: generated constructors are considered compact when they shouldn't

Reviewed-by: darcy, jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

• c5e0464: 8291456: com/sun/jdi/ClassUnloadEventTest.java failed with: Wrong number of class unload events: expected 10 got 4
• 8d4c077: 8295302: Do not use ArrayList when LambdaForm has a single ClassData
• 017e798: 8293939: Move continuation_enter_setup and friends
• f872467: 8255746: Make PrintCompilation available on a per method level
• 388a56e: 8294467: Fix sequence-point warnings in Hotspot
• ceb5b08: 8294468: Fix char-subscripts warnings in Hotspot
• 7b1c676: 8295662: jdk/incubator/vector tests fail "assert(VM_Version::supports_avx512vlbw()) failed"
• 5eaf568: 8295668: validate-source failure after JDK-8290011
• e238920: 8295372: CompactNumberFormat handling of number one with decimal part
• a5f6e31: 8295456: (ch) sun.nio.ch.Util::checkBufferPositionAligned gives misleading/incorrect error
• ... and 23 more: https://git.openjdk.org/jdk/compare/0233ba763d84e6da8ec03df5d021a13c5fbbc871...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[vicente-romero-oracle]

Test changes look good.

thanks for the review, and for the test :)

[lahodaj]

Looks good to me.

[vicente-romero-oracle]

/integrate

[vicente-romero-oracle]

Looks good to me.

thanks for the review

[openjdk]

Going to push as commit 95dd376.
Since your change was applied there have been 41 commits pushed to the master branch:

• 9b97162: 7039014: Confusing error message for method conflict
• 78dc497: 8294550: Sealed check for casts isn't applied to array components
• c08ff2c: 8294705: Disable an assertion in test/jdk/java/util/DoubleStreamSums/CompensatedSums.java
• d5a1521: 8295470: Update openjdk.java.net => openjdk.org URLs in test code
• 9d0cfd1: 8294948: Document IllegalArgumentException and NullPointerException thrown by URLStreamHandler::parseURL and URLStreamHandler::setURL
• dcd4650: 8294916: Cancelling a request must eventually cause its response body subscriber to be unregistered
• 4f994c0: 8295709: Linux AArch64 builds broken after JDK-8294438
• 545021b: 8294438: Fix misleading-indentation warnings in hotspot
• c5e0464: 8291456: com/sun/jdi/ClassUnloadEventTest.java failed with: Wrong number of class unload events: expected 10 got 4
• 8d4c077: 8295302: Do not use ArrayList when LambdaForm has a single ClassData
• ... and 31 more: https://git.openjdk.org/jdk/compare/0233ba763d84e6da8ec03df5d021a13c5fbbc871...master

Your commit was automatically rebased without conflicts.

[openjdk]

@vicente-romero-oracle Pushed as commit 95dd376.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.