Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295663 Rephrase introduction to testing.md #10763

Closed
wants to merge 3 commits into from

Conversation

LudwikJaniuk
Copy link
Contributor

@LudwikJaniuk LudwikJaniuk commented Oct 19, 2022

Old one made little sense for a new reader


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10763/head:pull/10763
$ git checkout pull/10763

Update a local copy of the PR:
$ git checkout pull/10763
$ git pull https://git.openjdk.org/jdk pull/10763/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10763

View PR using the GUI difftool:
$ git pr show -t 10763

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10763.diff

Old one made little sense for a new reader
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 19, 2022

👋 Welcome back lujaniuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 19, 2022

@LudwikJaniuk The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Oct 19, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 19, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 19, 2022

Webrevs

Copy link
Member

@magicus magicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@erikj79
Copy link
Member

erikj79 commented Oct 24, 2022

Could you tidy up the formatting of the markdown version? The line lengths are rather uneven.

@magicus
Copy link
Member

magicus commented Oct 24, 2022

Good point; I didn't notice. We try to keep the line length of markdown files below 79, if possible, so that they can be properly viewed on a 80-wide viewport.

Many editors have a "reflow lines" or similar function, that can help you.

@LudwikJaniuk
Copy link
Contributor Author

Sure thing, done.

Copy link
Member

@erikj79 erikj79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@LudwikJaniuk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 7, 2022

@LudwikJaniuk This pull request has not yet been marked as ready for integration.

@LudwikJaniuk LudwikJaniuk changed the title 8295663 Rephrased introduction to testing 8295663 Rephrase introduction to testing Nov 7, 2022
@LudwikJaniuk LudwikJaniuk changed the title 8295663 Rephrase introduction to testing 8295663 Rephrase introduction to testing.md Nov 7, 2022
@openjdk
Copy link

openjdk bot commented Nov 7, 2022

@LudwikJaniuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295663: Rephrase introduction to testing.md

Reviewed-by: ihse, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 523 new commits pushed to the master branch:

  • 520db1e: 8296485: BuildEEBasicConstraints.java test fails with SunCertPathBuilderException
  • b29817a: 8296479: Remove stray comment about POST_STRIP_CMD
  • b6ea69c: 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing
  • 3baad06: 8295953: Use enhanced-for cycle instead of Enumeration in sun.security
  • ba303c0: 8295893: Improve printing of Constant Pool Cache Entries
  • f8b2574: 8296137: diags-examples.xml is broken
  • 00d22f6: 8279164: Disable TLS_ECDH_* cipher suites
  • d634dde: 8295354: Remove G1 incremental non-copy time calculation
  • 8836b92: 8296226: Add constructors (String,Throwable) and (Throwable) to InvalidParameterException
  • 51f8e9b: 8296443: NMT: Remove cmdline_tracking_level handling code
  • ... and 513 more: https://git.openjdk.org/jdk/compare/1abf971b93222f422c0026cee944a6db214f955a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@magicus, @erikj79) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 7, 2022
@LudwikJaniuk
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 7, 2022
@openjdk
Copy link

openjdk bot commented Nov 7, 2022

@LudwikJaniuk
Your change (at version e80d40e) is now ready to be sponsored by a Committer.

@magicus
Copy link
Member

magicus commented Nov 7, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 7, 2022

Going to push as commit b6738c1.
Since your change was applied there have been 525 commits pushed to the master branch:

  • 7e85b41: 8296154: [macos] Change "/Applications" to "Applications" in DMG image
  • 60db5f2: 8294020: improve errors for record declarations
  • 520db1e: 8296485: BuildEEBasicConstraints.java test fails with SunCertPathBuilderException
  • b29817a: 8296479: Remove stray comment about POST_STRIP_CMD
  • b6ea69c: 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing
  • 3baad06: 8295953: Use enhanced-for cycle instead of Enumeration in sun.security
  • ba303c0: 8295893: Improve printing of Constant Pool Cache Entries
  • f8b2574: 8296137: diags-examples.xml is broken
  • 00d22f6: 8279164: Disable TLS_ECDH_* cipher suites
  • d634dde: 8295354: Remove G1 incremental non-copy time calculation
  • ... and 515 more: https://git.openjdk.org/jdk/compare/1abf971b93222f422c0026cee944a6db214f955a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 7, 2022
@openjdk openjdk bot closed this Nov 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 7, 2022
@openjdk
Copy link

openjdk bot commented Nov 7, 2022

@magicus @LudwikJaniuk Pushed as commit b6738c1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
3 participants