Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295662: jdk/incubator/vector tests fail "assert(VM_Version::supports_avx512vlbw()) failed" #10764

Closed
wants to merge 1 commit into from

Conversation

merykitty
Copy link
Member

@merykitty merykitty commented Oct 19, 2022

This patch removes the incorrectly used evmovdqub and uses evmovdqul because the former requires AVX512BW, which is unavailable on KNL settings. We have C2_MacroAssembler::load_vector already so we can use it here instead.

Thanks a lot.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295662: jdk/incubator/vector tests fail "assert(VM_Version::supports_avx512vlbw()) failed"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10764/head:pull/10764
$ git checkout pull/10764

Update a local copy of the PR:
$ git checkout pull/10764
$ git pull https://git.openjdk.org/jdk pull/10764/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10764

View PR using the GUI difftool:
$ git pr show -t 10764

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10764.diff

@merykitty merykitty marked this pull request as ready for review October 19, 2022 14:08
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 19, 2022

👋 Welcome back qamai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 19, 2022
@openjdk
Copy link

openjdk bot commented Oct 19, 2022

@merykitty The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Oct 19, 2022

Webrevs

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for proposing a fix that quickly, looks reasonable! I've submitted some testing (see comments in #10765).

@openjdk
Copy link

openjdk bot commented Oct 19, 2022

@merykitty This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295662: jdk/incubator/vector tests fail "assert(VM_Version::supports_avx512vlbw()) failed"

Reviewed-by: chagedorn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 19, 2022
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me too.

@chhagedorn
Copy link
Member

Testing looked good! Tier1 and 2 is completed and tier 3 is almost completed but the relevant tasks were successful. @merykitty you can proceed with the integration to reduce the noise in the JDK 20 CI.

Thanks,
Christian

@merykitty
Copy link
Member Author

Thanks very much for your reviews.
/integrate

@openjdk
Copy link

openjdk bot commented Oct 19, 2022

Going to push as commit 7b1c676.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 5eaf568: 8295668: validate-source failure after JDK-8290011
  • e238920: 8295372: CompactNumberFormat handling of number one with decimal part
  • a5f6e31: 8295456: (ch) sun.nio.ch.Util::checkBufferPositionAligned gives misleading/incorrect error
  • e27bea0: 8290011: IGV: Remove dead code and cleanup
  • d37ce4c: 8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation
  • 21aeb9e: 8295429: Update harfbuzz md file

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 19, 2022
@openjdk openjdk bot closed this Oct 19, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 19, 2022
@openjdk
Copy link

openjdk bot commented Oct 19, 2022

@merykitty Pushed as commit 7b1c676.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk
Copy link
Member

@merykitty - Thanks for jumping in on these test failures quickly and
for fixing the issue. I appreciate your efforts.

@XiaohongGong
Copy link

Thanks for fixing the issue so quickly @merykitty !

@merykitty merykitty deleted the wrongevmovdqub branch April 27, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
5 participants