Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295666: Linux x86 build fails after 8292591 #10771

Closed
wants to merge 1 commit into from

Conversation

bulasevich
Copy link
Contributor

@bulasevich bulasevich commented Oct 19, 2022

I have got build failure similar to recent Linux aarch64 and Linux Alpha Zero failures:

src/hotspot/os/linux/systemMemoryBarrier_linux.cpp:65:18: error: 'SYS_membarrier' was not declared in this scope
   return syscall(SYS_membarrier, cmd, flags, cpu_id); // cpu_id only on >= 5.10
                  ^~~~~~~~~~~~~~ 

The failure is known to be fixed by adding missing SYS_membarrier definition. The raw constant 375 is taken from the `linux-libc-dev_6.0.2-1_i386.deb' cross-compilation headers:

/usr/include/i386-linux-gnu/asm/unistd_32.h:#define __NR_membarrier 375
/usr/include/i386-linux-gnu/bits/syscall.h:# define SYS_membarrier __NR_membarrier


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10771/head:pull/10771
$ git checkout pull/10771

Update a local copy of the PR:
$ git checkout pull/10771
$ git pull https://git.openjdk.org/jdk pull/10771/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10771

View PR using the GUI difftool:
$ git pr show -t 10771

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10771.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 19, 2022

👋 Welcome back bulasevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 19, 2022

@bulasevich The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Oct 19, 2022
@bulasevich bulasevich marked this pull request as ready for review October 20, 2022 06:39
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 20, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 20, 2022

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay - and trivial. But I would have expected this to be reported weeks ago - has the linux-x86 build in GHA been failing all this time?

@openjdk
Copy link

openjdk bot commented Oct 20, 2022

@bulasevich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295666: Linux x86 build fails after 8292591

Reviewed-by: dholmes, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 351 new commits pushed to the master branch:

  • 545021b: 8294438: Fix misleading-indentation warnings in hotspot
  • c5e0464: 8291456: com/sun/jdi/ClassUnloadEventTest.java failed with: Wrong number of class unload events: expected 10 got 4
  • 8d4c077: 8295302: Do not use ArrayList when LambdaForm has a single ClassData
  • 017e798: 8293939: Move continuation_enter_setup and friends
  • f872467: 8255746: Make PrintCompilation available on a per method level
  • 388a56e: 8294467: Fix sequence-point warnings in Hotspot
  • ceb5b08: 8294468: Fix char-subscripts warnings in Hotspot
  • 7b1c676: 8295662: jdk/incubator/vector tests fail "assert(VM_Version::supports_avx512vlbw()) failed"
  • 5eaf568: 8295668: validate-source failure after JDK-8290011
  • e238920: 8295372: CompactNumberFormat handling of number one with decimal part
  • ... and 341 more: https://git.openjdk.org/jdk/compare/0b56b822436a0662170c11777ff0009b89a667eb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 20, 2022
@shipilev
Copy link
Member

Seems okay - and trivial. But I would have expected this to be reported weeks ago - has the linux-x86 build in GHA been failing all this time?

As previous bugs on other arches show, this would only happen if you (cross-)compile with older toolchains. GHA uses a reasonably modern toolchain to never hit it.

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right, thanks.

@bulasevich
Copy link
Contributor Author

Seems okay - and trivial. But I would have expected this to be reported weeks ago - has the linux-x86 build in GHA been failing all this time?

It depends on build machine /usr/include headers. My machine is pretty old.
Thank you!

@bulasevich
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 21, 2022

Going to push as commit 15bebf9.
Since your change was applied there have been 375 commits pushed to the master branch:

  • 5064718: 8294460: CodeSection::alignment checks for CodeBuffer::SECT_STUBS incorrectly
  • 8b010e0: 8030616: sun/management/jmxremote/bootstrap/RmiBootstrapTest fails intermittently with cannot find a free port
  • b35922b: 8295714: GHA ::set-output is deprecated and will be removed
  • dfd2d83: 8295657: SA: Allow larger object alignments
  • a345df2: 8280131: jcmd reports "Module jdk.jfr not found." when "jdk.management.jfr" is missing
  • ef62b61: 8295703: RISC-V: Remove implicit noreg temp register arguments in MacroAssembler
  • 6240431: 8295697: Resolve conflicts between serviceability/jvmti and nsk/jvmti shared code
  • 1164258: 8295124: Atomic::add to pointer type may return wrong value
  • d3eba85: 8295414: [Aarch64] C2: assert(false) failed: bad AD file
  • 028e8b3: 8137022: Concurrent refinement thread adjustment and (de-)activation suboptimal
  • ... and 365 more: https://git.openjdk.org/jdk/compare/0b56b822436a0662170c11777ff0009b89a667eb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 21, 2022
@openjdk openjdk bot closed this Oct 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 21, 2022
@openjdk
Copy link

openjdk bot commented Oct 21, 2022

@bulasevich Pushed as commit 15bebf9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants