Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295668: validate-source failure after JDK-8290011 #10772

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Oct 19, 2022

A trivia copyright fix for validate-source failure after JDK-8290011.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295668: validate-source failure after JDK-8290011

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10772/head:pull/10772
$ git checkout pull/10772

Update a local copy of the PR:
$ git checkout pull/10772
$ git pull https://git.openjdk.org/jdk pull/10772/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10772

View PR using the GUI difftool:
$ git pr show -t 10772

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10772.diff

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add hotspot-compiler

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 19, 2022

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review October 19, 2022 16:21
@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Oct 19, 2022
@openjdk
Copy link

openjdk bot commented Oct 19, 2022

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added rfr Pull request is ready for review hotspot-compiler hotspot-compiler-dev@openjdk.org labels Oct 19, 2022
@openjdk
Copy link

openjdk bot commented Oct 19, 2022

@dcubed-ojdk
The hotspot-compiler label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Oct 19, 2022

Webrevs

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial!

@dcubed-ojdk
Copy link
Member Author

@chhagedorn - Thanks for the fast review.

@dcubed-ojdk
Copy link
Member Author

/integrate auto

@openjdk
Copy link

openjdk bot commented Oct 19, 2022

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295668: validate-source failure after JDK-8290011

Reviewed-by: chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • e238920: 8295372: CompactNumberFormat handling of number one with decimal part

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated auto labels Oct 19, 2022
@openjdk
Copy link

openjdk bot commented Oct 19, 2022

@dcubed-ojdk This pull request will be automatically integrated when it is ready

@openjdk
Copy link

openjdk bot commented Oct 19, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 19, 2022

Going to push as commit 5eaf568.
Since your change was applied there has been 1 commit pushed to the master branch:

  • e238920: 8295372: CompactNumberFormat handling of number one with decimal part

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 19, 2022
@openjdk openjdk bot closed this Oct 19, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 19, 2022
@openjdk
Copy link

openjdk bot commented Oct 19, 2022

@openjdk[bot] Pushed as commit 5eaf568.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8295668 branch October 19, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto hotspot-compiler hotspot-compiler-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
2 participants