Skip to content

8064931: tools/javac/scope/DupUnsharedTest.java needs to be updated to add the bug id #10777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

archiecobbs
Copy link
Contributor

@archiecobbs archiecobbs commented Oct 20, 2022


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8064931: tools/javac/scope/DupUnsharedTest.java needs to be updated to add the bug id

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10777/head:pull/10777
$ git checkout pull/10777

Update a local copy of the PR:
$ git checkout pull/10777
$ git pull https://git.openjdk.org/jdk pull/10777/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10777

View PR using the GUI difftool:
$ git pr show -t 10777

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10777.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 20, 2022

👋 Welcome back archiecobbs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 20, 2022

@archiecobbs The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added compiler compiler-dev@openjdk.org rfr Pull request is ready for review labels Oct 20, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 20, 2022

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 17, 2022

@archiecobbs This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 15, 2022

@archiecobbs This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Dec 15, 2022
@archiecobbs
Copy link
Contributor Author

/open

@openjdk openjdk bot reopened this Dec 15, 2022
@openjdk
Copy link

openjdk bot commented Dec 15, 2022

@archiecobbs This pull request is now open

Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@openjdk
Copy link

openjdk bot commented Jan 4, 2023

@archiecobbs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8064931: tools/javac/scope/DupUnsharedTest.java needs to be updated to add the bug id

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 111 new commits pushed to the master branch:

  • e3035ba: 8299079: Better interface nmethod oop accesses
  • 41900b5: 8189338: JMX RMI Remote Mbean server connection hangs if the server stops responding during a SSL Handshake
  • 82deb5c: 8298601: Refactor archiving of java.lang.Module objects
  • 77ff197: 7030853: JDK 7 Serializable Swing classes not compatible with JDK 6
  • 38cfc59: 8299378: sprintf is deprecated in Xcode 14
  • ea25a56: 8299520: TestPrintXML.java output error messages in case compare fails
  • 92dfc73: 8294526: sun/security/provider/SubjectCodeSource.java no longer referenced
  • 3d0db02: Merge
  • a6a903d: 8288204: GVN Crash: assert() failed: correct memory chain
  • 37f8b05: 8298592: Add java man page documentation for ChaCha20 and Poly1305 intrinsics
  • ... and 101 more: https://git.openjdk.org/jdk/compare/da38d43fcc640ea9852db6c7c23817dcef7080d5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vicente-romero-oracle) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 4, 2023
@archiecobbs
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 4, 2023
@openjdk
Copy link

openjdk bot commented Jan 4, 2023

@archiecobbs
Your change (at version 63acabf) is now ready to be sponsored by a Committer.

@vicente-romero-oracle
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 4, 2023

Going to push as commit 4c0f24e.
Since your change was applied there have been 114 commits pushed to the master branch:

  • c6588d5: 8299158: Improve MD5 intrinsic on AArch64
  • c32a34c: 8299072: java_lang_ref_Reference::clear_referent should be GC agnostic
  • ccbcea8: 8299326: LinkResolver::resolve_field resolved_klass cannot be null
  • e3035ba: 8299079: Better interface nmethod oop accesses
  • 41900b5: 8189338: JMX RMI Remote Mbean server connection hangs if the server stops responding during a SSL Handshake
  • 82deb5c: 8298601: Refactor archiving of java.lang.Module objects
  • 77ff197: 7030853: JDK 7 Serializable Swing classes not compatible with JDK 6
  • 38cfc59: 8299378: sprintf is deprecated in Xcode 14
  • ea25a56: 8299520: TestPrintXML.java output error messages in case compare fails
  • 92dfc73: 8294526: sun/security/provider/SubjectCodeSource.java no longer referenced
  • ... and 104 more: https://git.openjdk.org/jdk/compare/da38d43fcc640ea9852db6c7c23817dcef7080d5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 4, 2023
@openjdk openjdk bot closed this Jan 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 4, 2023
@openjdk
Copy link

openjdk bot commented Jan 4, 2023

@vicente-romero-oracle @archiecobbs Pushed as commit 4c0f24e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants