8295650: JFR: jfr scrub should warn if an event type doesn't exist

[egahlin]

Hi,

It's easy to do a typo when using the 'jfr scrub' command. For example, a user may type "jdk.InitialEnvironmentVariables", "jdk.EnvironmentVariable" or "InitialEnvironmentVariable" and believe events have been removed from a recording file when they should have typed "jdk.InitialEnvironmentVariable" to filter out sensitive data.

To help users, a warning message is now written if an event filter doesn't match metadata available in the recording.

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8295650: JFR: jfr scrub should warn if an event type doesn't exist

Reviewers

• Markus Grönlund (@mgronlun - Reviewer) ⚠️ Review applies to bd317331

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10779/head:pull/10779
$ git checkout pull/10779

Update a local copy of the PR:
$ git checkout pull/10779
$ git pull https://git.openjdk.org/jdk pull/10779/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10779

View PR using the GUI difftool:
$ git pr show -t 10779

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10779.diff

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (ca4d50f4)
• 01: Full - Incremental (bd317331)
• 00: Full (0af0c2f2)

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295650: JFR: jfr scrub should warn if an event type doesn't exist

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

• 0c13d66: 8295530: Update Zlib Data Compression Library to Version 1.2.13
• 15bebf9: 8295666: Linux x86 build fails after 8292591
• 5064718: 8294460: CodeSection::alignment checks for CodeBuffer::SECT_STUBS incorrectly
• 8b010e0: 8030616: sun/management/jmxremote/bootstrap/RmiBootstrapTest fails intermittently with cannot find a free port
• b35922b: 8295714: GHA ::set-output is deprecated and will be removed
• dfd2d83: 8295657: SA: Allow larger object alignments
• a345df2: 8280131: jcmd reports "Module jdk.jfr not found." when "jdk.management.jfr" is missing
• ef62b61: 8295703: RISC-V: Remove implicit noreg temp register arguments in MacroAssembler
• 6240431: 8295697: Resolve conflicts between serviceability/jvmti and nsk/jvmti shared code
• 1164258: 8295124: Atomic::add to pointer type may return wrong value
• ... and 31 more: https://git.openjdk.org/jdk/compare/fc889577eaf3f564d896818c1d9b1eb6fa5a8758...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[egahlin]

/integrate

[openjdk]

Going to push as commit f41711e.
Since your change was applied there have been 41 commits pushed to the master branch:

• 0c13d66: 8295530: Update Zlib Data Compression Library to Version 1.2.13
• 15bebf9: 8295666: Linux x86 build fails after 8292591
• 5064718: 8294460: CodeSection::alignment checks for CodeBuffer::SECT_STUBS incorrectly
• 8b010e0: 8030616: sun/management/jmxremote/bootstrap/RmiBootstrapTest fails intermittently with cannot find a free port
• b35922b: 8295714: GHA ::set-output is deprecated and will be removed
• dfd2d83: 8295657: SA: Allow larger object alignments
• a345df2: 8280131: jcmd reports "Module jdk.jfr not found." when "jdk.management.jfr" is missing
• ef62b61: 8295703: RISC-V: Remove implicit noreg temp register arguments in MacroAssembler
• 6240431: 8295697: Resolve conflicts between serviceability/jvmti and nsk/jvmti shared code
• 1164258: 8295124: Atomic::add to pointer type may return wrong value
• ... and 31 more: https://git.openjdk.org/jdk/compare/fc889577eaf3f564d896818c1d9b1eb6fa5a8758...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit f41711e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.