8295714: GHA ::set-output is deprecated and will be removed

[magicus]

We need to transition to use the new $GITHUB_OUTPUT method instead.

This needs to be fixed since it is currently spamming the summary with warnings, and will stop working soon.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8295714: GHA ::set-output is deprecated and will be removed

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer) ⚠️ Review applies to 9d51fadf

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10785/head:pull/10785
$ git checkout pull/10785

Update a local copy of the PR:
$ git checkout pull/10785
$ git pull https://git.openjdk.org/jdk pull/10785/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10785

View PR using the GUI difftool:
$ git pr show -t 10785

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10785.diff

[bridgekeeper]

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@magicus The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (974fc045)
• 01: Full - Incremental (9c65693e)
• 00: Full (9d51fadf)

[shipilev]

Thanks! Looks fine, provided GHAs are green.

[openjdk]

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295714: GHA ::set-output is deprecated and will be removed

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

• dfd2d83: 8295657: SA: Allow larger object alignments
• a345df2: 8280131: jcmd reports "Module jdk.jfr not found." when "jdk.management.jfr" is missing
• ef62b61: 8295703: RISC-V: Remove implicit noreg temp register arguments in MacroAssembler
• 6240431: 8295697: Resolve conflicts between serviceability/jvmti and nsk/jvmti shared code
• 1164258: 8295124: Atomic::add to pointer type may return wrong value
• d3eba85: 8295414: [Aarch64] C2: assert(false) failed: bad AD file
• 028e8b3: 8137022: Concurrent refinement thread adjustment and (de-)activation suboptimal
• faa6b66: 8295715: Minimize disabled warnings in serviceability libs
• de1e0c5: 8295719: Remove unneeded disabled warnings in jdk.sctp
• 9612cf9: 8295529: Add link to JBS to README.md
• ... and 26 more: https://git.openjdk.org/jdk/compare/fc889577eaf3f564d896818c1d9b1eb6fa5a8758...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[magicus]

My fixes were green, but all of the annoying log spam was not gone. After some digging, it turned out that GitHub's own download-artifact@v3 was not clean, so I've upgraded it to download-artifact@v3.0.1 which was released just hours (!) ago. (Luckily I did not try to research this yesterday...)

[shipilev]

My fixes were green, but all of the annoying log spam was not gone. After some digging, it turned out that GitHub's own download-artifact@v3 was not clean, so I've upgraded it to download-artifact@v3.0.1 which was released just hours (!) ago. (Luckily I did not try to research this yesterday...)

Hah, DevOps goes brrrrr.

I would then wait for @v3 to catch up with the latest version, instead of sticking the @v3.0.1 that would keep us at outdated version as newer versions appear. We can try to re-test this PR next week, maybe?

[magicus]

digging some more

Actually, the v3 tag is already identical to v3.0.1, so there's probably just some caching at work here. I'll revert the latest commit, and then I say we're good to go. The upload-artifact issue will resolve itself, eventually, and we do not need to delay this fix awaiting that.

[shipilev]

Fine by me.

[magicus]

/integrate

[openjdk]

Going to push as commit b35922b.
Since your change was applied there have been 36 commits pushed to the master branch:

• dfd2d83: 8295657: SA: Allow larger object alignments
• a345df2: 8280131: jcmd reports "Module jdk.jfr not found." when "jdk.management.jfr" is missing
• ef62b61: 8295703: RISC-V: Remove implicit noreg temp register arguments in MacroAssembler
• 6240431: 8295697: Resolve conflicts between serviceability/jvmti and nsk/jvmti shared code
• 1164258: 8295124: Atomic::add to pointer type may return wrong value
• d3eba85: 8295414: [Aarch64] C2: assert(false) failed: bad AD file
• 028e8b3: 8137022: Concurrent refinement thread adjustment and (de-)activation suboptimal
• faa6b66: 8295715: Minimize disabled warnings in serviceability libs
• de1e0c5: 8295719: Remove unneeded disabled warnings in jdk.sctp
• 9612cf9: 8295529: Add link to JBS to README.md
• ... and 26 more: https://git.openjdk.org/jdk/compare/fc889577eaf3f564d896818c1d9b1eb6fa5a8758...master

Your commit was automatically rebased without conflicts.

[openjdk]

@magicus Pushed as commit b35922b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.