8295715: Minimize disabled warnings in serviceability libs

[magicus]

After JDK-8294281, it is now possible to disable warnings for individual files instead for whole libraries. I used this opportunity to go through all disabled warnings in the serviceability native libraries.

Any warnings that were only triggered in a few files were removed from the library as a whole, and changed to be only disabled for those files.

Some warnings didn't trigger in any file anymore, and could just be removed.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8295715: Minimize disabled warnings in serviceability libs

Reviewers

• Chris Plummer (@plummercj - Reviewer)
• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10786/head:pull/10786
$ git checkout pull/10786

Update a local copy of the PR:
$ git checkout pull/10786
$ git pull https://git.openjdk.org/jdk pull/10786/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10786

View PR using the GUI difftool:
$ git pr show -t 10786

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10786.diff

[bridgekeeper]

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@magicus The following labels will be automatically applied to this pull request:

• build
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (bf11d3e5)

[plummercj]

Changes look good.

[plummercj]

Is there any desire to clean up these warnings? I see back in 2015 there were a bunch of "Resolve disabled warnings for libXXX" bugs that you fixed. Any plans to make another pass. Seems like some of these warnings might be hiding real bugs.

[openjdk]

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295715: Minimize disabled warnings in serviceability libs

Reviewed-by: cjplummer, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 9612cf9: 8295529: Add link to JBS to README.md
• b37421e: 8295564: Norwegian Nynorsk Locale is missing formatting
• 6707bfb: 8029633: Raw inner class constructor ref should not perform diamond inference
• 7bc9692: 8294670: Enhanced switch statements have an implicit default which does not complete normally
• 95dd376: 8291914: generated constructors are considered compact when they shouldn't
• 9b97162: 7039014: Confusing error message for method conflict
• 78dc497: 8294550: Sealed check for casts isn't applied to array components
• c08ff2c: 8294705: Disable an assertion in test/jdk/java/util/DoubleStreamSums/CompensatedSums.java
• d5a1521: 8295470: Update openjdk.java.net => openjdk.org URLs in test code

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[magicus]

@plummercj I agree that it could very well be that these warnings are signs of real bugs. And yes, I plan to open new bugs requesting for these warnings to be fixed, if possible, if not someone else beats me to it.

However, it is mostly out of scope for me to fix, since domain knowledge by the respective component teams are usually required. And the old "Resolve disabled warnings for libXXX" JBS issues were created by me, but not fixed by me (in general).

[magicus]

/integrate

[openjdk]

Going to push as commit faa6b66.
Since your change was applied there have been 10 commits pushed to the master branch:

• de1e0c5: 8295719: Remove unneeded disabled warnings in jdk.sctp
• 9612cf9: 8295529: Add link to JBS to README.md
• b37421e: 8295564: Norwegian Nynorsk Locale is missing formatting
• 6707bfb: 8029633: Raw inner class constructor ref should not perform diamond inference
• 7bc9692: 8294670: Enhanced switch statements have an implicit default which does not complete normally
• 95dd376: 8291914: generated constructors are considered compact when they shouldn't
• 9b97162: 7039014: Confusing error message for method conflict
• 78dc497: 8294550: Sealed check for casts isn't applied to array components
• c08ff2c: 8294705: Disable an assertion in test/jdk/java/util/DoubleStreamSums/CompensatedSums.java
• d5a1521: 8295470: Update openjdk.java.net => openjdk.org URLs in test code

Your commit was automatically rebased without conflicts.

[openjdk]

@magicus Pushed as commit faa6b66.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.