8295717: Minimize disabled warnings in accessibility native code

[magicus]

After JDK-8294281, it is now possible to disable warnings for individual files instead for whole libraries. I used this opportunity to go through all disabled warnings in the accessibility native code.

Any warnings that were only triggered in a few files were removed from the library as a whole, and changed to be only disabled for those files.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8295717: Minimize disabled warnings in accessibility native code

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)
• Phil Race (@prrace - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10788/head:pull/10788
$ git checkout pull/10788

Update a local copy of the PR:
$ git checkout pull/10788
$ git pull https://git.openjdk.org/jdk pull/10788/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10788

View PR using the GUI difftool:
$ git pr show -t 10788

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10788.diff

[bridgekeeper]

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@magicus The following labels will be automatically applied to this pull request:

• build
• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (79b77410)

[erikj79]

This lib only has one cpp file, so this change doesn't seem that useful.

[magicus]

Heh, I did not notice that.

I'd still argue that this is a useful change. If some other file were ever to be added, it will not be covered by the blanked disabled warnings, and -- perhaps more important -- it is clear that these warnings can be addressed just by looking at a single file. This information has drastically increased the likelihood that a developer picks up the issue and actually resolves the warnings, as we have seen in other areas where I've done this "warnings-per-file" transition.

[prrace]

I suspect there's already a "fix disabled warnings in jdk.accessibility" .. can't we just fix that instead ?
I found it : https://bugs.openjdk.org/browse/JDK-8074847
Let me see what I can do about it.

[prrace]

but I'll approve this anyway .. no harm

[openjdk]

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295717: Minimize disabled warnings in accessibility native code

Reviewed-by: erikj, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

• aad81f2: 8293979: Resolve JVM_CONSTANT_Class references at CDS dump time
• 7cbf672: 8295811: serviceability/sa/TestObjectAlignment.java fails on x86_32
• adad59e: 8295762: [Vector API] Update generate_iota_indices for x86_32 after JDK-8293409
• b5efa2a: 8294538: missing is_unloading() check in SharedRuntime::fixup_callers_callsite()
• 6acbdb5: 8295427: popframe004: report more details on error
• 902162c: 8295239: Refactor java/util/Formatter/Basic script into a Java native test launcher
• f5dabf9: 8295088: Update External Spec page to show tabs for hosts
• 2181042: 8295375: debug agent class tracking should not piggy back on the cbClassPrepare() callback
• f41711e: 8295650: JFR: jfr scrub should warn if an event type doesn't exist
• 0c13d66: 8295530: Update Zlib Data Compression Library to Version 1.2.13
• ... and 22 more: https://git.openjdk.org/jdk/compare/9d0cfd1130b63f7acd67a52eb35c1ec38d43e514...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[magicus]

/integrate

[openjdk]

Going to push as commit 7a49c9b.
Since your change was applied there have been 37 commits pushed to the master branch:

• 7460661: 8294466: Minimize disabled warnings in java.desktop
• 89a94d0: 8293873: Centralize the initialization of UL
• 08d3ef4: 8295413: com/sun/jdi/EATests.java fails with compiler flag -XX:+StressReflectiveCode
• 65c84e0: 8295777: java/net/httpclient/ConnectExceptionTest.java should not rely on system resolver
• 329b49a: 8266900: java/net/httpclient/ShortResponseBody.java fails on windows with java.io.IOException: Unable to establish loopback connection
• aad81f2: 8293979: Resolve JVM_CONSTANT_Class references at CDS dump time
• 7cbf672: 8295811: serviceability/sa/TestObjectAlignment.java fails on x86_32
• adad59e: 8295762: [Vector API] Update generate_iota_indices for x86_32 after JDK-8293409
• b5efa2a: 8294538: missing is_unloading() check in SharedRuntime::fixup_callers_callsite()
• 6acbdb5: 8295427: popframe004: report more details on error
• ... and 27 more: https://git.openjdk.org/jdk/compare/9d0cfd1130b63f7acd67a52eb35c1ec38d43e514...master

Your commit was automatically rebased without conflicts.

[openjdk]

@magicus Pushed as commit 7a49c9b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.