8295447: NullPointerException with invalid pattern matching construct in constructor call

[biboudis]

In the examples below:

int i = (o instanceof Bar(int x))? 0 : 1;
meth(i);

meth((o instanceof Bar(int x))? 0 : 1);

the error DeconstructionPatternOnlyRecords was reported only on the first case but the compiler was still crashing in both occasions. NoType was passed and checkCastablePattern was letting an erroneous type to pass through the subtyping checks. The proposed fix addresses that in checkCastablePattern.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8295447: NullPointerException with invalid pattern matching construct in constructor call

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10791/head:pull/10791
$ git checkout pull/10791

Update a local copy of the PR:
$ git checkout pull/10791
$ git pull https://git.openjdk.org/jdk pull/10791/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10791

View PR using the GUI difftool:
$ git pr show -t 10791

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10791.diff

[bridgekeeper]

👋 Welcome back abimpoudis! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@biboudis The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c57d3496)

[bridgekeeper]

@biboudis This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[vicente-romero-oracle]

looks sensible

[openjdk]

@biboudis This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295447: NullPointerException with invalid pattern matching construct in constructor call

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 384 new commits pushed to the master branch:

• dd18d76: 8297173: usageTicks and totalTicks should be volatile to ensure that different threads get the latest ticks
• 2b6dbc7: 8293856: AArch64: Remove clear_inst_mark from aarch64_enc_java_dynamic_call
• 2f063b8: 8296846: Minor cleanup of some dead code in Flow.java
• ab6b7ef: 8296901: Do not create unsigned certificate and CRL
• 7b3984c: 8296463: Memory leak in JVM_StartThread with the integration of Virtual threads
• 373e52c: 8296785: Use realloc for CHeap-allocated BitMaps
• a53be20: 8282404: DrawStringWithInfiniteXform.java failed with "RuntimeException: drawString with InfiniteXform transform takes long time"
• 66228f7: 8297074: Use enhanced-for cycle instead of Enumeration in javax.crypto
• 819af69: 8249693: java/nio/channels/FileChannel/FileExtensionAndMap.java uses @ignore w/o bug id
• 9c432a0: 8297165: Update Pandoc to version 2.19.2 for Oracle builds
• ... and 374 more: https://git.openjdk.org/jdk/compare/1d883c5312721980898f91898665b528948a985b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vicente-romero-oracle) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[biboudis]

/integrate

[openjdk]

@biboudis
Your change (at version c57d349) is now ready to be sponsored by a Committer.

[vicente-romero-oracle]

/sponsor

[openjdk]

Going to push as commit 6c05771.
Since your change was applied there have been 496 commits pushed to the master branch:

• 76a24c3: 8297145: Add a @sealedGraph tag to ConstantDesc
• 099b42f: 8297148: Add a @sealedGraph tag to CallSite
• 85ddd8f: 8295253: Remove kludge from v1_0/PerfDataBuffer.java
• 952e100: 8297431: [JVMCI] HotSpotJVMCIRuntime.encodeThrowable should not throw an exception
• 08e6a82: 8297590: [TESTBUG] HotSpotResolvedJavaFieldTest does not run
• 4f65570: 8294583: JShell: NPE in switch with non existing record pattern
• fd910f7: 8297384: Add IR tests for existing idealizations of arithmetic nodes
• cfe5a37: 8297556: Parse::check_interpreter_type fails with assert "must constrain OSR typestate"
• 74d3bac: 8297417: Poly1305IntrinsicFuzzTest fails with tag mismatch exception
• 0ed8b33: 8297385: Remove duplicated null typos in javadoc
• ... and 486 more: https://git.openjdk.org/jdk/compare/1d883c5312721980898f91898665b528948a985b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@vicente-romero-oracle @biboudis Pushed as commit 6c05771.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.