Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266900: java/net/httpclient/ShortResponseBody.java fails on windows with java.io.IOException: Unable to establish loopback connection #10794

Closed
wants to merge 2 commits into from

Conversation

djelinski
Copy link
Member

@djelinski djelinski commented Oct 20, 2022

This PR reduces the number of requests performed by ShortResponseBody* tests from 570 to 100. It also reduces the number of httpclients created from one per request/URL to one per 10 requests. This in turn will translate to reduced frequency of failures caused by all ephemeral ports being in use.

Before this patch each test URL was repeated 12 times: 3 times with a dedicated client, then 3 more times with a client shared across all requests, repeated for sync and async.
After this patch each test URL is checked only 2 times, once with sync and once with async call.

The tests continue to pass.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8266900: java/net/httpclient/ShortResponseBody.java fails on windows with java.io.IOException: Unable to establish loopback connection

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10794/head:pull/10794
$ git checkout pull/10794

Update a local copy of the PR:
$ git checkout pull/10794
$ git pull https://git.openjdk.org/jdk pull/10794/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10794

View PR using the GUI difftool:
$ git pr show -t 10794

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10794.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 20, 2022

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8266900 8266900: java/net/httpclient/ShortResponseBody.java fails on windows with java.io.IOException: Unable to establish loopback connection Oct 20, 2022
@openjdk
Copy link

openjdk bot commented Oct 20, 2022

@djelinski The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Oct 20, 2022
@djelinski djelinski marked this pull request as ready for review October 20, 2022 13:06
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 20, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 20, 2022

Webrevs

@@ -703,7 +686,6 @@ public void setup() throws Exception {

@AfterTest
public void teardown() throws Exception {
if (sharedClient != null) sharedClient = null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably null client here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary. client is an instance field and will be GCed as soon as the framework is done with the test.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right we don't use the ReferenceTracker here yet. Maybe we should (but that's for later).

@openjdk
Copy link

openjdk bot commented Oct 20, 2022

@djelinski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266900: java/net/httpclient/ShortResponseBody.java fails on windows with java.io.IOException: Unable to establish loopback connection

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • b37421e: 8295564: Norwegian Nynorsk Locale is missing formatting
  • 6707bfb: 8029633: Raw inner class constructor ref should not perform diamond inference
  • 7bc9692: 8294670: Enhanced switch statements have an implicit default which does not complete normally
  • 95dd376: 8291914: generated constructors are considered compact when they shouldn't
  • 9b97162: 7039014: Confusing error message for method conflict
  • 78dc497: 8294550: Sealed check for casts isn't applied to array components

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 20, 2022
@djelinski
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 24, 2022

Going to push as commit 329b49a.
Since your change was applied there have been 30 commits pushed to the master branch:

  • aad81f2: 8293979: Resolve JVM_CONSTANT_Class references at CDS dump time
  • 7cbf672: 8295811: serviceability/sa/TestObjectAlignment.java fails on x86_32
  • adad59e: 8295762: [Vector API] Update generate_iota_indices for x86_32 after JDK-8293409
  • b5efa2a: 8294538: missing is_unloading() check in SharedRuntime::fixup_callers_callsite()
  • 6acbdb5: 8295427: popframe004: report more details on error
  • 902162c: 8295239: Refactor java/util/Formatter/Basic script into a Java native test launcher
  • f5dabf9: 8295088: Update External Spec page to show tabs for hosts
  • 2181042: 8295375: debug agent class tracking should not piggy back on the cbClassPrepare() callback
  • f41711e: 8295650: JFR: jfr scrub should warn if an event type doesn't exist
  • 0c13d66: 8295530: Update Zlib Data Compression Library to Version 1.2.13
  • ... and 20 more: https://git.openjdk.org/jdk/compare/c08ff2c7b88e94885f6b4701654a9e47e49567b0...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 24, 2022
@openjdk openjdk bot closed this Oct 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 24, 2022
@openjdk
Copy link

openjdk bot commented Oct 24, 2022

@djelinski Pushed as commit 329b49a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@djelinski djelinski deleted the shortresponse-tests branch March 8, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
2 participants