Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295732: Directly embed TruncatedSeqs in G1Analytics #10795

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Oct 20, 2022

Hi all,

can I have reviews for this change that directly embeds TruncatedSeq into G1Analytics. There is no reason imho to use the additional indirection.

This is based on PR#10793, so please review this if not already done.

Testing: local compilation, gha

Thanks,
Thomas


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295732: Directly embed TruncatedSeqs in G1Analytics

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10795/head:pull/10795
$ git checkout pull/10795

Update a local copy of the PR:
$ git checkout pull/10795
$ git pull https://git.openjdk.org/jdk pull/10795/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10795

View PR using the GUI difftool:
$ git pr show -t 10795

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10795.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 20, 2022

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into pr/10793 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 20, 2022
@openjdk
Copy link

openjdk bot commented Oct 20, 2022

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Oct 20, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 20, 2022

Webrevs

@tschatzl tschatzl force-pushed the submit/8295732-directly-embed-truncatedseq branch from cbe7f71 to c51deca Compare October 20, 2022 14:22
@openjdk-notifier
Copy link

@tschatzl Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/10793 to master October 25, 2022 10:22
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout submit/8295732-directly-embed-truncatedseq
git fetch https://git.openjdk.org/jdk master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented Oct 25, 2022

@tschatzl this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout submit/8295732-directly-embed-truncatedseq
git fetch https://git.openjdk.org/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented Oct 25, 2022

⚠️ @tschatzl This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Oct 25, 2022
@openjdk
Copy link

openjdk bot commented Oct 25, 2022

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295732: Directly embed TruncatedSeqs in G1Analytics

Reviewed-by: iwalulya, sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed merge-conflict Pull request has merge conflict with target branch labels Oct 25, 2022
@tschatzl
Copy link
Contributor Author

Thanks for your reviews @kstefanj @walulyai
/integrate

@openjdk
Copy link

openjdk bot commented Oct 25, 2022

Going to push as commit ef60608.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 3e49f8f: 8295839: G1: Single threaded phases (within parallel phases) report as using multiple threads in logs
  • 427f506: 8279366: CDS should allow alternative locations for JAR files in classpath
  • 3a873d3: 8295808: GrowableArray should support capacity management
  • 6289600: 8295810: cleanup debug agent removeThread() api
  • 5c4d99a: 8295118: G1: Clear CLD claim marks concurrently
  • af2de97: 8287754: Update jib GNU make dependency on Windows to latest cygwin build
  • 9051dde: 8294993: LingeredApp test update

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 25, 2022
@openjdk openjdk bot closed this Oct 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 25, 2022
@openjdk
Copy link

openjdk bot commented Oct 25, 2022

@tschatzl Pushed as commit ef60608.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8295732-directly-embed-truncatedseq branch November 17, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants