-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8295276: AArch64: Add backend support for half float conversion intrinsics #10796
Conversation
…nsics This patch adds aarch64 backend support for library intrinsics that implement conversions between half-precision and single-precision floats. Ran the following benchmarks to assess the performance with this patch - org.openjdk.bench.java.math.Fp16ConversionBenchmark.floatToFloat16 org.openjdk.bench.java.math.Fp16ConversionBenchmark.float16ToFloat The performance (ops/ms) gain with the patch on an ARM NEON machine is shown below - Benchmark Gain Fp16ConversionBenchmark.float16ToFloat 3.42 Fp16ConversionBenchmark.floatToFloat16 5.85
👋 Welcome back bkilambi! A progress list of the required criteria for merging this PR into |
@Bhavana-Kilambi The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Could anyone please take a look at this PR and give their feedback ? Thank you .. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me but needs another review.
@Bhavana-Kilambi This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 394 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@nick-arm, @theRealAph, @nsjian) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
/integrate |
@Bhavana-Kilambi |
/sponsor |
Going to push as commit 891c706.
Your commit was automatically rebased without conflicts. |
@nsjian @Bhavana-Kilambi Pushed as commit 891c706. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This patch adds aarch64 backend support for library intrinsics that implement conversions between half-precision and single-precision floats.
Ran the following benchmarks to assess the performance with this patch -
org.openjdk.bench.java.math.Fp16ConversionBenchmark.floatToFloat16 org.openjdk.bench.java.math.Fp16ConversionBenchmark.float16ToFloat
The performance (ops/ms) gain with the patch on an ARM NEON machine is shown below -
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10796/head:pull/10796
$ git checkout pull/10796
Update a local copy of the PR:
$ git checkout pull/10796
$ git pull https://git.openjdk.org/jdk pull/10796/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10796
View PR using the GUI difftool:
$ git pr show -t 10796
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10796.diff