-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8287754: Update jib GNU make dependency on Windows to latest cygwin build #10805
Conversation
👋 Welcome back erikj! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that with these changes the build is using make 4.3, and is using all cores as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
@erikj79 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 396 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit af2de97.
Your commit was automatically rebased without conflicts. |
For Oracle internal builds we control the version of GNU Make (currently fixed at 4.0). In Cygwin this is causing problems as the now rather dated GNU Make binary we use isn't compatible with Cygwin.dll version 3.3 or later. To work around this, I'm making the dependency dynamic on the version of Cygwin. If the currently running Cygwin is new enough, the dependency will be on GNU make 4.3.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10805/head:pull/10805
$ git checkout pull/10805
Update a local copy of the PR:
$ git checkout pull/10805
$ git pull https://git.openjdk.org/jdk pull/10805/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10805
View PR using the GUI difftool:
$ git pr show -t 10805
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10805.diff