Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255955: Shenandoah: Only STW GC should process concurrent roots at pauses #1081

Closed

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Nov 5, 2020

This is a followup of JDK-8255847.

In early versions of Shenandoah, it marked through weak roots when class unloading is disabled. This is no longer the case.

After moving weak roots (except that JVMTI weak root) processing to concurrent phase for concurrent GC, only STW GCs (degenerated GC and full GC) need to process concurrent weak roots at pause.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8255955: Shenandoah: Only STW GC should process concurrent roots at pauses

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1081/head:pull/1081
$ git checkout pull/1081

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 5, 2020

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 5, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2020

@zhengyu123 The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc shenandoah labels Nov 5, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 5, 2020

Webrevs

rkennke
rkennke approved these changes Nov 5, 2020
Copy link
Contributor

@rkennke rkennke left a comment

Looks good to me, thank you!

@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2020

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255955: Shenandoah: Only STW GC should process concurrent roots at pauses

Reviewed-by: rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • d6f0940: 8255913: Decrease number of iterations in TestMaxCachedBufferSize
  • 1b59595: 8255914: [AOT] Using AOT flag should give warning when AOT is not included in build
  • a50fdd5: 8219014: (bf) Add absolute bulk put methods which accept a source Buffer
  • 3a02578: 8255452: Doing GC during JVMTI MethodExit event posting breaks return oop
  • ba2ff3a: 8250637: UseOSErrorReporting times out (on Mac and Linux)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 5, 2020
@zhengyu123
Copy link
Contributor Author

@zhengyu123 zhengyu123 commented Nov 5, 2020

/integrate

@openjdk openjdk bot closed this Nov 5, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 5, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2020

@zhengyu123 Since your change was applied there have been 5 commits pushed to the master branch:

  • d6f0940: 8255913: Decrease number of iterations in TestMaxCachedBufferSize
  • 1b59595: 8255914: [AOT] Using AOT flag should give warning when AOT is not included in build
  • a50fdd5: 8219014: (bf) Add absolute bulk put methods which accept a source Buffer
  • 3a02578: 8255452: Doing GC during JVMTI MethodExit event posting breaks return oop
  • ba2ff3a: 8250637: UseOSErrorReporting times out (on Mac and Linux)

Your commit was automatically rebased without conflicts.

Pushed as commit fc894ab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@zhengyu123 zhengyu123 deleted the JDK-8255955-stw-conc-roots branch Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated shenandoah
2 participants