8219810: javac throws NullPointerException

[archiecobbs]

JVMS 4.5 states:

Each field of a class may have at most one of its ACC_PUBLIC, ACC_PRIVATE, and ACC_PROTECTED flags set (JLS §8.3.1), and must not have both its ACC_FINAL and ACC_VOLATILE flags set (JLS §8.3.1.4).

and JVMS 4.6 states:

Each method of a class may have at most one of its ACC_PUBLIC, ACC_PRIVATE, and ACC_PROTECTED flags set (JLS §8.4.3).

However, when reading class files these illegal combinations are not actually checked, and this can lead to compiler crashes as in the bug example.

This patch adds checks for these illegal combinations.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8219810: javac throws NullPointerException

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10826/head:pull/10826
$ git checkout pull/10826

Update a local copy of the PR:
$ git checkout pull/10826
$ git pull https://git.openjdk.org/jdk pull/10826/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10826

View PR using the GUI difftool:
$ git pr show -t 10826

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10826.diff

[bridgekeeper]

👋 Welcome back archiecobbs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@archiecobbs The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (90aebcd5)
• 02: Full - Incremental (94cb9924)
• 01: Full - Incremental (b2667d90)
• 00: Full (5d7fa500)

[bridgekeeper]

@archiecobbs This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[archiecobbs]

keepalive

[vicente-romero-oracle]

lgtm

[vicente-romero-oracle]

/sponsor

[openjdk]

@archiecobbs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8219810: javac throws NullPointerException

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 123 new commits pushed to the master branch:

• b9758d2: 8200610: Compiling fails with java.nio.file.ReadOnlyFileSystemException
• df1caf9: Merge
• a17f505: 8299476: PPC64 Zero build fails after JDK-8286302
• b743519: 8293824: gc/whitebox/TestConcMarkCycleWB.java failed "RuntimeException: assertTrue: expected true, was false"
• 8254cbb: 8299483: ProblemList java/text/Format/NumberFormat/CurrencyFormat.java
• 031829d: 8298324: Unable to run shell test with make
• 3eb85d1: 8299235: broken link referencing missing id
• 6a07fd0: 8155259: Suspicious buffer allocation in com.sun.tools.javac.file.BaseFileManager
• 4c0f24e: 8064931: tools/javac/scope/DupUnsharedTest.java needs to be updated to add the bug id
• c6588d5: 8299158: Improve MD5 intrinsic on AArch64
• ... and 113 more: https://git.openjdk.org/jdk/compare/da38d43fcc640ea9852db6c7c23817dcef7080d5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vicente-romero-oracle) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@vicente-romero-oracle The change author (@archiecobbs) must issue an integrate command before the integration can be sponsored.

[archiecobbs]

/integrate

[openjdk]

@archiecobbs
Your change (at version 90aebcd) is now ready to be sponsored by a Committer.

[vicente-romero-oracle]

/sponsor

[openjdk]

Going to push as commit 44be5ed.
Since your change was applied there have been 123 commits pushed to the master branch:

• b9758d2: 8200610: Compiling fails with java.nio.file.ReadOnlyFileSystemException
• df1caf9: Merge
• a17f505: 8299476: PPC64 Zero build fails after JDK-8286302
• b743519: 8293824: gc/whitebox/TestConcMarkCycleWB.java failed "RuntimeException: assertTrue: expected true, was false"
• 8254cbb: 8299483: ProblemList java/text/Format/NumberFormat/CurrencyFormat.java
• 031829d: 8298324: Unable to run shell test with make
• 3eb85d1: 8299235: broken link referencing missing id
• 6a07fd0: 8155259: Suspicious buffer allocation in com.sun.tools.javac.file.BaseFileManager
• 4c0f24e: 8064931: tools/javac/scope/DupUnsharedTest.java needs to be updated to add the bug id
• c6588d5: 8299158: Improve MD5 intrinsic on AArch64
• ... and 113 more: https://git.openjdk.org/jdk/compare/da38d43fcc640ea9852db6c7c23817dcef7080d5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@vicente-romero-oracle @archiecobbs Pushed as commit 44be5ed.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.