Skip to content

8295811: serviceability/sa/TestObjectAlignment.java fails on x86_32#10829

Closed
DamonFool wants to merge 1 commit intoopenjdk:masterfrom
DamonFool:JDK-8295811
Closed

8295811: serviceability/sa/TestObjectAlignment.java fails on x86_32#10829
DamonFool wants to merge 1 commit intoopenjdk:masterfrom
DamonFool:JDK-8295811

Conversation

@DamonFool
Copy link
Member

@DamonFool DamonFool commented Oct 22, 2022

It fails on x86_32 due to Unrecognized VM option ObjectAlignmentInBytes=8.
So let's only run the test on 64-bit platforms.

Thanks.
Best regards,
Jie


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295811: serviceability/sa/TestObjectAlignment.java fails on x86_32

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10829/head:pull/10829
$ git checkout pull/10829

Update a local copy of the PR:
$ git checkout pull/10829
$ git pull https://git.openjdk.org/jdk pull/10829/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10829

View PR using the GUI difftool:
$ git pr show -t 10829

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10829.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 22, 2022

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 22, 2022
@openjdk
Copy link

openjdk bot commented Oct 22, 2022

@DamonFool The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Oct 22, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 22, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 22, 2022

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295811: serviceability/sa/TestObjectAlignment.java fails on x86_32

Reviewed-by: cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 22, 2022
@DamonFool
Copy link
Member Author

Thanks @plummercj for your review.
/integrate

@openjdk
Copy link

openjdk bot commented Oct 23, 2022

Going to push as commit 7cbf672.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 23, 2022
@openjdk openjdk bot closed this Oct 23, 2022
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Oct 23, 2022
@DamonFool DamonFool deleted the JDK-8295811 branch October 23, 2022 04:01
@openjdk openjdk bot removed the rfr Pull request is ready for review label Oct 23, 2022
@openjdk
Copy link

openjdk bot commented Oct 23, 2022

@DamonFool Pushed as commit 7cbf672.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants