8295839: G1: Single threaded phases (within parallel phases) report as using multiple threads in logs

[tschatzl]

Hi all,

can I have reviews for this change that changes log output to properly report single-threaded (sub-)phases number of threads?

E.g.

 [87.104s][debug][gc,phases] GC(1412) Ext Root Scanning (ms): Min: 0.0, Avg: 0.0, Max: 0.0, Diff: 0.0, Sum: 0.1, Workers: 6
[...]
[87.104s][trace][gc,phases] GC(1412) CLDG Roots (ms): Min: 0.0, Avg: 0.0, Max: 0.0, Diff: 0.0, Sum: 0.0, Workers: 1
[87.104s][trace][gc,phases] GC(1412) CM RefProcessor Roots (ms): Min: 0.0, Avg: 0.0, Max: 0.0, Diff: 0.0, Sum: 0.0, Workers: 1
[...] 

instead of

 [87.104s][debug][gc,phases] GC(1412) Ext Root Scanning (ms): Min: 0.0, Avg: 0.0, Max: 0.0, Diff: 0.0, Sum: 0.1, Workers: 6
[...]
[87.104s][trace][gc,phases] GC(1412) CLDG Roots (ms): Min: 0.0, Avg: 0.0, Max: 0.0, Diff: 0.0, Sum: 0.0, Workers: 6
[87.104s][trace][gc,phases] GC(1412) CM RefProcessor Roots (ms): Min: 0.0, Avg: 0.0, Max: 0.0, Diff: 0.0, Sum: 0.0, Workers: 6
[...] 

Testing: local testing of some log files, gha

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8295839: G1: Single threaded phases (within parallel phases) report as using multiple threads in logs

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10833/head:pull/10833
$ git checkout pull/10833

Update a local copy of the PR:
$ git checkout pull/10833
$ git pull https://git.openjdk.org/jdk pull/10833/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10833

View PR using the GUI difftool:
$ git pr show -t 10833

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10833.diff

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c3507072)

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295839: G1: Single threaded phases (within parallel phases) report as using multiple threads in logs

Reviewed-by: ayang, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 5ac6f18: 8290010: IGV: Fix UndoRedo Action
• c055dfc: 8294565: IGV: ClassCastException when clicking on an edge in the graph
• 3898385: 8295461: IGV: Wrong src/dest nodes highlighted for edge
• d50b6eb: 8295776: [JVMCI] Add x86 CPU flags for MPK and CET
• 5596d9a: 8288493: Document JDK specific system properties in jdk.httpserver

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tschatzl]

Thanks @walulyai @albertnetymk for your reviews.
/integrate

[openjdk]

Going to push as commit 3e49f8f.
Since your change was applied there have been 24 commits pushed to the master branch:

• 427f506: 8279366: CDS should allow alternative locations for JAR files in classpath
• 3a873d3: 8295808: GrowableArray should support capacity management
• 6289600: 8295810: cleanup debug agent removeThread() api
• 5c4d99a: 8295118: G1: Clear CLD claim marks concurrently
• af2de97: 8287754: Update jib GNU make dependency on Windows to latest cygwin build
• 9051dde: 8294993: LingeredApp test update
• f37a605: 8295212: G1: Add wrapper for TruncatedSeqs that need separation by gc phase
• 6673cd8: 8295554: Move the "sizecalc.h" to the correct location
• 706d1b7: 8295798: (ch) Test java/nio/channels/Channels/ReadXBytes.java is very slow on Windows
• 89dafc0: 8292699: Improve printing of classes in native debugger
• ... and 14 more: https://git.openjdk.org/jdk/compare/7a49c9baa1d4ad7df90e7ca626ec48ba76881822...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit 3e49f8f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.