8295844: jdk/test/whitebox/CPUInfoTest.java failed with "not all features are known: expected true, was false"

[vnkozlov]

JDK-8295776 added new x86 CPU flags checks but did not update CPUInfoTest.java.
Add missing x86 CPU's flags to CPUInfoTest.java.

Tested with tier1 when CPUInfoTest.java is ran.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8295844: jdk/test/whitebox/CPUInfoTest.java failed with "not all features are known: expected true, was false"

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer) ⚠️ Review applies to acd6b1f6
• Doug Simon (@dougxc - Committer) ⚠️ Review applies to 014e26ee

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10837/head:pull/10837
$ git checkout pull/10837

Update a local copy of the PR:
$ git checkout pull/10837
$ git pull https://git.openjdk.org/jdk pull/10837/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10837

View PR using the GUI difftool:
$ git pr show -t 10837

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10837.diff

[bridgekeeper]

👋 Welcome back kvn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[tschatzl]

Lgtm.

[openjdk]

@vnkozlov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295844: jdk/test/whitebox/CPUInfoTest.java failed with "not all features are known: expected true, was false"

Reviewed-by: tschatzl, dnsimon

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• df81b3c: 8295738: Automate javax/swing/JFileChooser/FileSizeCheck.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@vnkozlov To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• kulla
• net
• nio
• security
• serviceability
• shenandoah

[vnkozlov]

There were 2 cases when we forgot update CPUInfoTest.java and JVMCI's AMD64.java. I added comment to vm_version_x86.hpp to remind about that. I also aligned flags in CPUInfoTest.java to match existing padding.

[vnkozlov]

/label add hotspot

[openjdk]

@vnkozlov
The hotspot label was successfully added.

[mlbridge]

Webrevs

• 00: Full (5f815ac0)

[vnkozlov]

/integrate

[openjdk]

Going to push as commit e122321.
Since your change was applied there has been 1 commit pushed to the master branch:

• df81b3c: 8295738: Automate javax/swing/JFileChooser/FileSizeCheck.java

Your commit was automatically rebased without conflicts.

[openjdk]

@vnkozlov Pushed as commit e122321.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.