Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295879: JFR: Remove warnings in the jdk.jfr module #10850

Closed
wants to merge 1 commit into from

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Oct 25, 2022

Hi,

Could I have a review of PR that removes some warnings in the jdk.jfr module.

Testing: jdk/jdk/jfr + tier1

Thanks
Erik


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295879: JFR: Remove warnings in the jdk.jfr module

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10850/head:pull/10850
$ git checkout pull/10850

Update a local copy of the PR:
$ git checkout pull/10850
$ git pull https://git.openjdk.org/jdk pull/10850/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10850

View PR using the GUI difftool:
$ git pr show -t 10850

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10850.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 25, 2022

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 25, 2022

@egahlin The following labels will be automatically applied to this pull request:

  • hotspot-jfr
  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added net net-dev@openjdk.org hotspot-jfr hotspot-jfr-dev@openjdk.org labels Oct 25, 2022
@egahlin egahlin marked this pull request as ready for review October 25, 2022 12:25
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 25, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 25, 2022

Webrevs

@egahlin
Copy link
Member Author

egahlin commented Oct 25, 2022

/label remove net

@openjdk openjdk bot removed the net net-dev@openjdk.org label Oct 25, 2022
@openjdk
Copy link

openjdk bot commented Oct 25, 2022

@egahlin
The net label was successfully removed.

@caizixian caizixian mentioned this pull request Oct 25, 2022
3 tasks
@openjdk
Copy link

openjdk bot commented Oct 25, 2022

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295879: JFR: Remove warnings in the jdk.jfr module

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 0caea81: 8295895: build error after JDK-8279366
  • ee0dec8: 8295838: Document why we do not print Code Cache Roots phase in G1 logging
  • ef60608: 8295732: Directly embed TruncatedSeqs in G1Analytics
  • 3e49f8f: 8295839: G1: Single threaded phases (within parallel phases) report as using multiple threads in logs
  • 427f506: 8279366: CDS should allow alternative locations for JAR files in classpath
  • 3a873d3: 8295808: GrowableArray should support capacity management
  • 6289600: 8295810: cleanup debug agent removeThread() api
  • 5c4d99a: 8295118: G1: Clear CLD claim marks concurrently
  • af2de97: 8287754: Update jib GNU make dependency on Windows to latest cygwin build
  • 9051dde: 8294993: LingeredApp test update

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 25, 2022
@egahlin
Copy link
Member Author

egahlin commented Oct 26, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 26, 2022

Going to push as commit 78454b6.
Since your change was applied there have been 22 commits pushed to the master branch:

  • 33ff80d: 8295402: G1: Tighten assertion in G1ScanHRForRegionClosure::scan_heap_roots
  • 303548b: 8294752: G1: Remove redundant checks in check_obj_during_refinement
  • cf121df: 8295889: NMT preinit code does not handle allocation errors
  • 772be2e: 8295868: 32-bit Windows build failures after JDK-8294466
  • e173fd7: 8295885: GHA: Bump gcc versions
  • b2878c9: 8295710: remove os::dll_file_extension
  • e3a5a34: 8295767: Remove unused fields in sun.awt.geom.Edge
  • 324bec1: 8295863: JFR: Use expected size for Maps and Sets
  • 3bd3caf: 8294486: Remove vmTestbase/nsk/jvmti/ tests ported to serviceability/jvmti.
  • fec6174: 8295816: jdwp jck tests failing with "FATAL ERROR in native method: JDWP SetTag, jvmtiError=JVMTI_ERROR_WRONG_PHASE(112)"
  • ... and 12 more: https://git.openjdk.org/jdk/compare/f37a6055c469956a1e69715840a61f56b5cea425...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 26, 2022
@openjdk openjdk bot closed this Oct 26, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 26, 2022
@openjdk
Copy link

openjdk bot commented Oct 26, 2022

@egahlin Pushed as commit 78454b6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
2 participants