Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8291781: assert(!is_visited) failed: visit only once with -XX:+SuperWordRTDepCheck #10868

Closed
wants to merge 1 commit into from

Conversation

fg1417
Copy link

@fg1417 fg1417 commented Oct 26, 2022

-XX:+SuperWordRTDepCheck is a develop flag and misses proper implementation. But when enabled, it could change code path, resulting in the failures in JDK-8291781 and JDK-8291881. As @vnkozlov suggested in JDK-8291781, the small patch converts the flag to pure debug code to avoid effect on code generation.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8291781: assert(!is_visited) failed: visit only once with -XX:+SuperWordRTDepCheck

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10868/head:pull/10868
$ git checkout pull/10868

Update a local copy of the PR:
$ git checkout pull/10868
$ git pull https://git.openjdk.org/jdk pull/10868/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10868

View PR using the GUI difftool:
$ git pr show -t 10868

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10868.diff

…ordRTDepCheck

`-XX:+SuperWordRTDepCheck` is a develop flag and misses proper
implementation. But when enabled, it could change code path,
resulting in the failures in JDK-8291781 and JDK-8291881. As
kvn suggested in JDK-8291781, the small patch converts the
flag to pure debug code to avoid effect on code generation.
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 26, 2022

👋 Welcome back fgao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 26, 2022
@openjdk
Copy link

openjdk bot commented Oct 26, 2022

@fg1417 The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Oct 26, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 26, 2022

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Oct 26, 2022

@fg1417 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291781: assert(!is_visited) failed: visit only once with -XX:+SuperWordRTDepCheck

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 43 new commits pushed to the master branch:

  • fd668dc: 8295537: Enhance TRACE_METHOD_LINKAGE to show the target MethodHandle
  • 182c215: 8295994: Remove left over InetAddressContainer class
  • 78763fc: 8295000: java/util/Formatter/Basic test cleanup
  • 907d583: 8295323: Unnecessary HashTable usage in StyleSheet
  • 2157145: 8293858: Change PKCS7 code to use default SecureRandom impl instead of SHA1PRNG
  • b8ad6cd: 8294461: wrong effectively final determination by javac
  • d667895: 8294399: (ch) Refactor some methods out of sun.nio.ch.UnixFileDispatcherImpl
  • 628820f: 8283093: JMX connections should default to using an ObjectInputFilter
  • 521e712: 8286431: Do not use resource array in posix mmap_attach_shared()
  • 4d9a1cd: 8292159: TYPE_USE annotations on generic type arguments of record components discarded
  • ... and 33 more: https://git.openjdk.org/jdk/compare/89dafc002f934f7381a150e3f04fd1f830d183a4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 26, 2022
@vnkozlov
Copy link
Contributor

Please, also verify fix with compiler/codegen/Test*Vect.java tests which failed according to JDK-8291881

@fg1417
Copy link
Author

fg1417 commented Oct 27, 2022

Please, also verify fix with compiler/codegen/Test*Vect.java tests which failed according to JDK-8291881

Thanks for your review @vnkozlov. Yes, I verified it on our internal aarch64 and x86 platforms enabling -XX:+SuperWordRTDepCheck. Without the fix, some compiler/codegen/Test*Vect.java tests failed, while with the fix, all these tests passed on both platforms. Do I need to update these testcase files with the option? Thanks.

@vnkozlov
Copy link
Contributor

Do I need to update these testcase files with the option?

No need to update them.

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me test it (with this flag enabled by default) before you push.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Oct 27, 2022
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too. Please wait until Vladimir's testing passed.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 27, 2022
@vnkozlov
Copy link
Contributor

@fg1417 my testing passed. You can integrate.

@fg1417
Copy link
Author

fg1417 commented Oct 28, 2022

@fg1417 my testing passed. You can integrate.

Thanks for your review and test work, @vnkozlov @TobiHartmann.

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 28, 2022
@openjdk
Copy link

openjdk bot commented Oct 28, 2022

@fg1417
Your change (at version bae4ec0) is now ready to be sponsored by a Committer.

@pfustc
Copy link
Member

pfustc commented Oct 28, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 28, 2022

Going to push as commit 4b89fce.
Since your change was applied there have been 44 commits pushed to the master branch:

  • d5d3424: 8295405: Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests
  • fd668dc: 8295537: Enhance TRACE_METHOD_LINKAGE to show the target MethodHandle
  • 182c215: 8295994: Remove left over InetAddressContainer class
  • 78763fc: 8295000: java/util/Formatter/Basic test cleanup
  • 907d583: 8295323: Unnecessary HashTable usage in StyleSheet
  • 2157145: 8293858: Change PKCS7 code to use default SecureRandom impl instead of SHA1PRNG
  • b8ad6cd: 8294461: wrong effectively final determination by javac
  • d667895: 8294399: (ch) Refactor some methods out of sun.nio.ch.UnixFileDispatcherImpl
  • 628820f: 8283093: JMX connections should default to using an ObjectInputFilter
  • 521e712: 8286431: Do not use resource array in posix mmap_attach_shared()
  • ... and 34 more: https://git.openjdk.org/jdk/compare/89dafc002f934f7381a150e3f04fd1f830d183a4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 28, 2022
@openjdk openjdk bot closed this Oct 28, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 28, 2022
@openjdk
Copy link

openjdk bot commented Oct 28, 2022

@pfustc @fg1417 Pushed as commit 4b89fce.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@fg1417
Copy link
Author

fg1417 commented Oct 28, 2022

The commit message edited by bot shows only one of reviewers. That's weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
4 participants