Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295814: jdk/jshell/CommandCompletionTest.java fails with "lists don't have the same size expected [2] but found [1]" #10870

Closed
wants to merge 4 commits into from

Conversation

asotona
Copy link
Member

@asotona asotona commented Oct 26, 2022

File completion in CommandCompletionTest::testSet intermittently fails.
Also message provided by org.testng.Assert::assertEquals is also not very verbose when comparing collections:
"lists don't have the same size expected [2] but found [1]".

Cause of the failure is in the expected side of the assertion (CommandCompletionTest::getRootDirectories), which may conatain duplicates. While the actual side of the assertion is distinct (CommandCompletionTest::computeCompletions).

Proposed patch de-duplicates CommandCompletionTest::getRootDirectories and adds full description of the expected result to the error message for future debugging.

Please review.

Thanks,
Adam


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295814: jdk/jshell/CommandCompletionTest.java fails with "lists don't have the same size expected [2] but found [1]"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10870/head:pull/10870
$ git checkout pull/10870

Update a local copy of the PR:
$ git checkout pull/10870
$ git pull https://git.openjdk.org/jdk pull/10870/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10870

View PR using the GUI difftool:
$ git pr show -t 10870

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10870.diff

…t have the same size expected [2] but found [1]"
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 26, 2022

👋 Welcome back asotona! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8295814: jdk/jshell/CommandCompletionTest.java fails with "lists don'… 8295814: jdk/jshell/CommandCompletionTest.java fails with "lists don't have the same size expected [2] but found [1]" Oct 26, 2022
@openjdk
Copy link

openjdk bot commented Oct 26, 2022

@asotona The following label will be automatically applied to this pull request:

  • kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the kulla kulla-dev@openjdk.org label Oct 26, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 26, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 26, 2022

Webrevs

@dcubed-ojdk
Copy link
Member

@lahodaj
Copy link
Contributor

lahodaj commented Oct 26, 2022

+1 on the improvement for the logging (although it is unfortunate the TestNG assert is not logging the difference properly by itself, as old asserts did).

But, I wonder if there are particular data showing the problem is in duplicate entries in getRootDirectories(). Offhand, that would seem like a less likely explanation. The expected value is a combination of files and directories in the current working directory, and the root directories. To me, it would seem like a more likely explanation that there is a file or directory that initially exists in the current working directory, but then disappears before the completion is computed.

@asotona
Copy link
Member Author

asotona commented Nov 10, 2022

Please review proposed patch to test minimal size of the expected completion response for problematic test cases, instead of verification of the exact content.

Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK.

@openjdk
Copy link

openjdk bot commented Nov 15, 2022

@asotona This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295814: jdk/jshell/CommandCompletionTest.java fails with "lists don't have the same size expected [2] but found [1]"

Reviewed-by: jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 206 new commits pushed to the master branch:

  • 6f467cd: 8295934: IGV: keep node selection when changing view or graph
  • 9adb728: 8295070: Introduce more target combinations for compiler flags
  • 8ab70d3: 8294775: Shenandoah: reduce contention on _threads_in_evac
  • 5551cb6: 8293166: jdk/jfr/jvm/TestDumpOnCrash.java fails on Linux ppc64le and Linux aarch64
  • 8a9eabb: 8296786: Limit VM modes for com/sun/jdi/JdbLastErrorTest.java
  • 873eccd: 8296923: JFR: jfr --version should return System.getProperty("java version")
  • 93d6b1f: 8295711: Rename ZBarrierSetAssembler::load_at parameter name from "tmp_thread" to "tmp2"
  • 2f7dc5c: 8296089: Remove debug agent code for special handling of Thread.resume()
  • c71d87e: 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3
  • a7c2338: 8296900: CertificateValidity fields are not optional
  • ... and 196 more: https://git.openjdk.org/jdk/compare/78454b69da1434da18193d32813c59126348c9ea...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 15, 2022
@asotona
Copy link
Member Author

asotona commented Nov 15, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Nov 15, 2022

Going to push as commit a45c9af.
Since your change was applied there have been 207 commits pushed to the master branch:

  • d0fae43: 8294947: Use 64bit atomics in patch_verified_entry on x86_64
  • 6f467cd: 8295934: IGV: keep node selection when changing view or graph
  • 9adb728: 8295070: Introduce more target combinations for compiler flags
  • 8ab70d3: 8294775: Shenandoah: reduce contention on _threads_in_evac
  • 5551cb6: 8293166: jdk/jfr/jvm/TestDumpOnCrash.java fails on Linux ppc64le and Linux aarch64
  • 8a9eabb: 8296786: Limit VM modes for com/sun/jdi/JdbLastErrorTest.java
  • 873eccd: 8296923: JFR: jfr --version should return System.getProperty("java version")
  • 93d6b1f: 8295711: Rename ZBarrierSetAssembler::load_at parameter name from "tmp_thread" to "tmp2"
  • 2f7dc5c: 8296089: Remove debug agent code for special handling of Thread.resume()
  • c71d87e: 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3
  • ... and 197 more: https://git.openjdk.org/jdk/compare/78454b69da1434da18193d32813c59126348c9ea...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 15, 2022
@openjdk openjdk bot closed this Nov 15, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 15, 2022
@openjdk
Copy link

openjdk bot commented Nov 15, 2022

@asotona Pushed as commit a45c9af.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated kulla kulla-dev@openjdk.org
3 participants