Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269235: serviceability/sa/ClhsdbJstackXcompStress.java timed out #10876

Closed
wants to merge 1 commit into from

Conversation

plummercj
Copy link
Contributor

@plummercj plummercj commented Oct 26, 2022

The test uses the default timeout, which is 2 minutes. The timeoutfactor being used ix 4x, so this gives 8 minutes or 480 seconds. This is why we see:

Timeout refired 480 times

When this happens, usually the test takes a little over 10 minutes to complete (and pass). However, the most recent failure says:

elapsed time (seconds): 764.054

So this is nearly 13 minutes. I'm going to give the test 20 minutes (when timeoutfactor 4x is used), so this translate to specifying a timeout of 5 minutes (300 seconds).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8269235: serviceability/sa/ClhsdbJstackXcompStress.java timed out

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10876/head:pull/10876
$ git checkout pull/10876

Update a local copy of the PR:
$ git checkout pull/10876
$ git pull https://git.openjdk.org/jdk pull/10876/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10876

View PR using the GUI difftool:
$ git pr show -t 10876

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10876.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 26, 2022

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8269235 8269235: serviceability/sa/ClhsdbJstackXcompStress.java timed out Oct 26, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 26, 2022
@openjdk
Copy link

openjdk bot commented Oct 26, 2022

@plummercj The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Oct 26, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 26, 2022

Webrevs

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up. This is a trivial fix.

@openjdk
Copy link

openjdk bot commented Oct 26, 2022

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269235: serviceability/sa/ClhsdbJstackXcompStress.java timed out

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 26, 2022
@plummercj
Copy link
Contributor Author

Thanks Dan!

/integrate

@openjdk
Copy link

openjdk bot commented Oct 26, 2022

Going to push as commit c2d7a35.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 58a7141: 8295066: Folding of loads is broken in C2 after JDK-8242115

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 26, 2022
@openjdk openjdk bot closed this Oct 26, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 26, 2022
@openjdk
Copy link

openjdk bot commented Oct 26, 2022

@plummercj Pushed as commit c2d7a35.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
2 participants