8294881: test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose003/TestDescription.java fails

[lmesnik]

Change Thread.resume() to error reporting and add some time to complete thread.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8294881: test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose003/TestDescription.java fails

Reviewers

• Chris Plummer (@plummercj - Reviewer)
• Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10877/head:pull/10877
$ git checkout pull/10877

Update a local copy of the PR:
$ git checkout pull/10877
$ git pull https://git.openjdk.org/jdk pull/10877/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10877

View PR using the GUI difftool:
$ git pr show -t 10877

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10877.diff

[bridgekeeper]

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lmesnik The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 04: Full - Incremental (04bc9155)
• 03: Full - Incremental (bcb59cdd)
• 02: Full - Incremental (e29bf4a6)
• 01: Full - Incremental (75c440b7)
• 00: Full (260e9c2b)

[dcubed-ojdk]

Thanks for fixing this issue. It shows up in my stress testing
cycles every week.

[plummercj]

I think this is a dup of JDK-8226587, and can happen with all the dispose tests. Probably would be wise to fix them all with this PR.

The reason this separate CR was filed is because with the removal of Thread.resume(), the failure mode changed, so it was not recognized as being the same as JDK-8226587

[lmesnik]

The fix applied to all dispose tests.

[openjdk]

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294881: test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose003/TestDescription.java fails

Reviewed-by: cjplummer, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 197 new commits pushed to the master branch:

• 873eccd: 8296923: JFR: jfr --version should return System.getProperty("java version")
• 93d6b1f: 8295711: Rename ZBarrierSetAssembler::load_at parameter name from "tmp_thread" to "tmp2"
• 2f7dc5c: 8296089: Remove debug agent code for special handling of Thread.resume()
• c71d87e: 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3
• a7c2338: 8296900: CertificateValidity fields are not optional
• 3eb789a: 8296171: Compiler incorrectly rejects code with variadic method references
• 749335d: 8291911: java/io/File/GetXSpace.java fails with "53687091200 != 161051996160"
• 95b8405: 8296431: PushbackInputStream should override transferTo
• e269dc0: 8293681: ResponseAPDU getData() method javadoc
• 8c472e4: 8294217: Assertion failure: parsing found no loops but there are some
• ... and 187 more: https://git.openjdk.org/jdk/compare/a8450b37ee6ea83c5354ba0892ac71df19e5a1cc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[sspitsyn]

Looks good.
Thank you for update.
Serguei

[lmesnik]

/integrate

[openjdk]

Going to push as commit 216c6f6.
Since your change was applied there have been 209 commits pushed to the master branch:

• 6aef3a4: 8262435: Clarify the behavior of a few inherited ZipInputStream methods
• c042b8e: 8294731: Improve multiplicative inverse for secp256r1 implementation
• d3051a7: 8296736: Some PKCS9Attribute can be created but cannot be encoded
• decb1b7: 8286800: Assert in PhaseIdealLoop::dump_real_LCA is too strong
• c49e484: 8294739: jdk/jshell/ToolShiftTabTest.java timed out
• a45c9af: 8295814: jdk/jshell/CommandCompletionTest.java fails with "lists don't have the same size expected [2] but found [1]"
• d0fae43: 8294947: Use 64bit atomics in patch_verified_entry on x86_64
• 6f467cd: 8295934: IGV: keep node selection when changing view or graph
• 9adb728: 8295070: Introduce more target combinations for compiler flags
• 8ab70d3: 8294775: Shenandoah: reduce contention on _threads_in_evac
• ... and 199 more: https://git.openjdk.org/jdk/compare/a8450b37ee6ea83c5354ba0892ac71df19e5a1cc...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lmesnik Pushed as commit 216c6f6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.