Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8156593: DataOutput.write(byte[],int,int) and its implementations do not specify index out bounds #10890

Closed
wants to merge 2 commits into from

Conversation

bplb
Copy link
Member

@bplb bplb commented Oct 27, 2022

Add @throws IndexOutOfBoundsException {@inheritDoc} to some write(byte[],int,int) and read(byte[],int,int) methods of some classes in the java.io package to make things a bit clearer.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request to be approved

Issues

  • JDK-8156593: DataOutput.write(byte[],int,int) and its implementations do not specify index out bounds
  • JDK-8296138: DataOutput.write(byte[],int,int) and its implementations do not specify index out bounds (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10890/head:pull/10890
$ git checkout pull/10890

Update a local copy of the PR:
$ git checkout pull/10890
$ git pull https://git.openjdk.org/jdk pull/10890/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10890

View PR using the GUI difftool:
$ git pr show -t 10890

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10890.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 27, 2022

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 27, 2022
@openjdk
Copy link

openjdk bot commented Oct 27, 2022

@bplb The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Oct 27, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 27, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 28, 2022

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8156593: DataOutput.write(byte[],int,int) and its implementations do not specify index out bounds

Reviewed-by: alanb, aturbanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 28, 2022
@openjdk openjdk bot added csr Pull request needs approved CSR before integration ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated csr Pull request needs approved CSR before integration labels Oct 31, 2022
@bplb
Copy link
Member Author

bplb commented Oct 31, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 31, 2022

Going to push as commit 4999f2c.
Since your change was applied there have been 25 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 31, 2022
@openjdk openjdk bot closed this Oct 31, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 31, 2022
@openjdk
Copy link

openjdk bot commented Oct 31, 2022

@bplb Pushed as commit 4999f2c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the DataOutput-write-8156593 branch November 1, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants