JDK-8295914: Add a header to generated HTML files in specs#10891
JDK-8295914: Add a header to generated HTML files in specs#10891jonathan-gibbons wants to merge 3 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back jjg! A progress list of the required criteria for merging this PR into |
|
@jonathan-gibbons The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
erikj79
left a comment
There was a problem hiding this comment.
Build changes look fine in general.
irisclark
left a comment
There was a problem hiding this comment.
Your changes look good! Can't wait to see this in a promotion.
|
@jonathan-gibbons This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit d17bf51.
Your commit was automatically rebased without conflicts. |
|
@jonathan-gibbons Pushed as commit d17bf51. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review some updates to the parts of the build system related to building the documentation.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10891/head:pull/10891$ git checkout pull/10891Update a local copy of the PR:
$ git checkout pull/10891$ git pull https://git.openjdk.org/jdk pull/10891/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10891View PR using the GUI difftool:
$ git pr show -t 10891Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10891.diff