Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8295914: Add a header to generated HTML files in specs #10891

Closed

Conversation

jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented Oct 27, 2022

Please review some updates to the parts of the build system related to building the documentation.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295914: Add a header to generated HTML files in specs

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10891/head:pull/10891
$ git checkout pull/10891

Update a local copy of the PR:
$ git checkout pull/10891
$ git pull https://git.openjdk.org/jdk pull/10891/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10891

View PR using the GUI difftool:
$ git pr show -t 10891

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10891.diff

@jonathan-gibbons jonathan-gibbons marked this pull request as draft October 27, 2022 20:50
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 27, 2022

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 27, 2022

@jonathan-gibbons The following labels will be automatically applied to this pull request:

  • build
  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added javadoc javadoc-dev@openjdk.org build build-dev@openjdk.org labels Oct 27, 2022
@jonathan-gibbons jonathan-gibbons marked this pull request as ready for review October 27, 2022 21:04
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 27, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 27, 2022

Webrevs

Copy link
Member

@erikj79 erikj79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build changes look fine in general.

make/Docs.gmk Outdated Show resolved Hide resolved
Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes look good! Can't wait to see this in a promotion.

@openjdk
Copy link

openjdk bot commented Oct 31, 2022

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295914: Add a header to generated HTML files in specs

Reviewed-by: erikj, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 37107fc: 8296007: crash in runtime/DefineClass/NullClassBytesTest.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 31, 2022
@jonathan-gibbons
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 1, 2022

Going to push as commit d17bf51.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 9911405: 8282958: Rendering issues of borders, TextFields on Windows High-DPI systems
  • 2fb64a4: 8296162: [aarch64] Remove unused Address::_is_lval
  • 15b8b45: 8296161: [aarch64] Remove unused "pcrel" addressing mode tag
  • f829b5a: 8280378: [IR Framework] Support IR matching for different compile phases
  • da0ae51: 8296167: test/langtools/tools/jdeps/jdkinternals/ShowReplacement.java failing after JDK-8296072
  • 0d0bd7b: 8296072: CertAttrSet::encode and DerEncoder::derEncode should write into DerOutputStream
  • 37107fc: 8296007: crash in runtime/DefineClass/NullClassBytesTest.java

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 1, 2022
@openjdk openjdk bot closed this Nov 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 1, 2022
@openjdk
Copy link

openjdk bot commented Nov 1, 2022

@jonathan-gibbons Pushed as commit d17bf51.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jonathan-gibbons jonathan-gibbons deleted the 8295914.spec-headers branch November 1, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org
3 participants