Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256660: Disable DTLS 1.0 #10905

Closed
wants to merge 5 commits into from
Closed

Conversation

seanjmullan
Copy link
Member

@seanjmullan seanjmullan commented Oct 28, 2022

Disable DTLS 1.0 by default. This version of DTLS has weakened over time and lacks support for stronger cipher suites. DTLS 1.0 correlates with version 1.1 of TLS which has already been disabled by default in JDK 16. The IETF has deprecated this version of DTLS (along with TLS 1.0 and 1.1) in RFC 8996: https://www.rfc-editor.org/rfc/rfc8996.html.

CSR: https://bugs.openjdk.org/browse/JDK-8280507


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request to be approved

Issues

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10905/head:pull/10905
$ git checkout pull/10905

Update a local copy of the PR:
$ git checkout pull/10905
$ git pull https://git.openjdk.org/jdk pull/10905/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10905

View PR using the GUI difftool:
$ git pr show -t 10905

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10905.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 28, 2022

👋 Welcome back mullan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review csr Pull request needs approved CSR before integration labels Oct 28, 2022
@openjdk
Copy link

openjdk bot commented Oct 28, 2022

@seanjmullan The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Oct 28, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 28, 2022

Webrevs

Copy link
Member

@XueleiFan XueleiFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@haimaychao
Copy link
Contributor

Looks good.

Copy link
Contributor

@bradfordwetmore bradfordwetmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also.

Took a bit to figure out 1352, but got it now.

@seanjmullan
Copy link
Member Author

/csr

@openjdk
Copy link

openjdk bot commented Oct 29, 2022

@seanjmullan an approved CSR request is already required for this pull request.

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Oct 31, 2022
@openjdk
Copy link

openjdk bot commented Oct 31, 2022

@seanjmullan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8256660: Disable DTLS 1.0

Reviewed-by: xuelei, hchao, wetmore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 31, 2022
@seanjmullan
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 31, 2022

Going to push as commit 16744b3.
Since your change was applied there have been 32 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 31, 2022
@openjdk openjdk bot closed this Oct 31, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 31, 2022
@openjdk
Copy link

openjdk bot commented Oct 31, 2022

@seanjmullan Pushed as commit 16744b3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
4 participants