Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296130: G1: Remove G1YoungCollector::_target_pause_time_ms #10919

Closed

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Oct 31, 2022

Simple change of narrowing down the scope of target-pause-time.

Test: hotspot_gc


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296130: G1: Remove G1YoungCollector::_target_pause_time_ms

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10919/head:pull/10919
$ git checkout pull/10919

Update a local copy of the PR:
$ git checkout pull/10919
$ git pull https://git.openjdk.org/jdk pull/10919/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10919

View PR using the GUI difftool:
$ git pr show -t 10919

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10919.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2022

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8296130 8296130: G1: Remove G1YoungCollector::_target_pause_time_ms Oct 31, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 31, 2022
@openjdk
Copy link

openjdk bot commented Oct 31, 2022

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Oct 31, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 31, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 1, 2022

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296130: G1: Remove G1YoungCollector::_target_pause_time_ms

Reviewed-by: iwalulya, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • 8de3eda: 8295476: Split G1 cost per byte predictor on gc phase
  • 2634eff: 8295646: Ignore zero pairs in address descriptors read by dwarf parser
  • 50d91a3: 8057113: (fs) Path should have a method to obtain the filename extension
  • d17bf51: 8295914: Add a header to generated HTML files in specs
  • 9911405: 8282958: Rendering issues of borders, TextFields on Windows High-DPI systems
  • 2fb64a4: 8296162: [aarch64] Remove unused Address::_is_lval
  • 15b8b45: 8296161: [aarch64] Remove unused "pcrel" addressing mode tag
  • f829b5a: 8280378: [IR Framework] Support IR matching for different compile phases
  • da0ae51: 8296167: test/langtools/tools/jdeps/jdkinternals/ShowReplacement.java failing after JDK-8296072
  • 0d0bd7b: 8296072: CertAttrSet::encode and DerEncoder::derEncode should write into DerOutputStream
  • ... and 8 more: https://git.openjdk.org/jdk/compare/274ea1db5b248968c1ff1c5c24d75f07fb8a0600...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 1, 2022
Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a couple potential formatting suggestions.

@@ -2024,8 +2024,7 @@ bool G1CollectedHeap::try_collect_concurrently(GCCause::Cause cause,
// start a concurrent cycle.
LOG_COLLECT_CONCURRENTLY(cause, "attempt %u", i);
VM_G1TryInitiateConcMark op(gc_counter,
cause,
policy()->max_pause_time_ms());
cause);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider removing the line break here.

@@ -2652,8 +2649,7 @@ HeapWord* G1CollectedHeap::do_collection_pause(size_t word_size,
assert_heap_not_locked_and_not_at_safepoint();
VM_G1CollectForAllocation op(word_size,
gc_count_before,
gc_cause,
policy()->max_pause_time_ms());
gc_cause);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider removing the line breaks here.

@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 2, 2022

Going to push as commit 38c1f2a.
Since your change was applied there have been 22 commits pushed to the master branch:

  • 2bd24c4: 8295968: RISC-V: Rename some assembler intrinsic functions for RVV 1.0
  • 1a58cb1: 8233697: CHT: Iteration parallelization
  • 7619602: 8296136: Use correct register in aarch64_enc_fast_unlock()
  • 47d513b: 8252075: Documentation error in LayoutManager2 interface
  • 8de3eda: 8295476: Split G1 cost per byte predictor on gc phase
  • 2634eff: 8295646: Ignore zero pairs in address descriptors read by dwarf parser
  • 50d91a3: 8057113: (fs) Path should have a method to obtain the filename extension
  • d17bf51: 8295914: Add a header to generated HTML files in specs
  • 9911405: 8282958: Rendering issues of borders, TextFields on Windows High-DPI systems
  • 2fb64a4: 8296162: [aarch64] Remove unused Address::_is_lval
  • ... and 12 more: https://git.openjdk.org/jdk/compare/274ea1db5b248968c1ff1c5c24d75f07fb8a0600...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 2, 2022
@openjdk openjdk bot closed this Nov 2, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 2, 2022
@openjdk
Copy link

openjdk bot commented Nov 2, 2022

@albertnetymk Pushed as commit 38c1f2a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the g1-remove-pause-target-arg branch November 2, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants