-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8279913: obsolete ExtendedDTraceProbes #10930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back epeter! A progress list of the required criteria for merging this PR into |
TobiHartmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
|
@eme64 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
chhagedorn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
Thanks @TobiHartmann and @chhagedorn for the reviews :) |
|
Going to push as commit 1950747.
Your commit was automatically rebased without conflicts. |
Obsoleted ExtendedDTraceProbes.
Removed all uses of the flag, it now shows this warning when used:
Ignoring option ExtendedDTraceProbes; support was removed in 20.0Documentation was already changed in JDK-8279047
Verified warning message in dtrace build, and regular build.
Ran automatic regression tests.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10930/head:pull/10930$ git checkout pull/10930Update a local copy of the PR:
$ git checkout pull/10930$ git pull https://git.openjdk.org/jdk pull/10930/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10930View PR using the GUI difftool:
$ git pr show -t 10930Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10930.diff