Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8279913: obsolete ExtendedDTraceProbes #10930

Closed
wants to merge 2 commits into from
Closed

Conversation

eme64
Copy link
Contributor

@eme64 eme64 commented Nov 1, 2022

Obsoleted ExtendedDTraceProbes.
Removed all uses of the flag, it now shows this warning when used:
Ignoring option ExtendedDTraceProbes; support was removed in 20.0

Documentation was already changed in JDK-8279047

Verified warning message in dtrace build, and regular build.
Ran automatic regression tests.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10930/head:pull/10930
$ git checkout pull/10930

Update a local copy of the PR:
$ git checkout pull/10930
$ git pull https://git.openjdk.org/jdk pull/10930/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10930

View PR using the GUI difftool:
$ git pr show -t 10930

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10930.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 1, 2022

👋 Welcome back epeter! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 1, 2022

@eme64 The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Nov 1, 2022
@eme64 eme64 marked this pull request as ready for review November 2, 2022 05:37
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 2, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 2, 2022

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented Nov 2, 2022

@eme64 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279913: obsolete ExtendedDTraceProbes

Reviewed-by: thartmann, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 50d91a3: 8057113: (fs) Path should have a method to obtain the filename extension
  • d17bf51: 8295914: Add a header to generated HTML files in specs
  • 9911405: 8282958: Rendering issues of borders, TextFields on Windows High-DPI systems
  • 2fb64a4: 8296162: [aarch64] Remove unused Address::_is_lval
  • 15b8b45: 8296161: [aarch64] Remove unused "pcrel" addressing mode tag
  • f829b5a: 8280378: [IR Framework] Support IR matching for different compile phases
  • da0ae51: 8296167: test/langtools/tools/jdeps/jdkinternals/ShowReplacement.java failing after JDK-8296072
  • 0d0bd7b: 8296072: CertAttrSet::encode and DerEncoder::derEncode should write into DerOutputStream

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 2, 2022
Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@eme64
Copy link
Contributor Author

eme64 commented Nov 3, 2022

Thanks @TobiHartmann and @chhagedorn for the reviews :)
/integrate

@openjdk
Copy link

openjdk bot commented Nov 3, 2022

Going to push as commit 1950747.
Since your change was applied there have been 27 commits pushed to the master branch:

  • 13b20e0: 8296262: Remove dead code from InstanceKlass::signature_name()
  • fd60036: 8296188: Update style and header in JDWP Protocol spec and JVMTI spec
  • c7b95a8: 8296163: [aarch64] Cleanup Pre/Post addressing mode classes
  • f84b0ad: 8295670: Remove duplication in java/util/Formatter/Basic*.java
  • a124d8e: 8296115: Allow for compiling the JDK with strict standards conformance
  • 491d43c: 8289838: ZGC: OOM before clearing all SoftReferences
  • a1c349f: 8290063: IGV: Give the graphs a unique number in the outline
  • b807470: 8296235: IGV: Change shortcut to delete graph from ctrl+del to del
  • e15d241: 8295991: java/net/httpclient/CancelRequestTest.java fails intermittently
  • 16a041a: 8296142: CertAttrSet::(getName|getElements|delete) are mostly useless
  • ... and 17 more: https://git.openjdk.org/jdk/compare/37107fc1574a4191987420d88f7182e63c7da60c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 3, 2022
@openjdk openjdk bot closed this Nov 3, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 3, 2022
@openjdk
Copy link

openjdk bot commented Nov 3, 2022

@eme64 Pushed as commit 1950747.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants