Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296108: (tz) Update Timezone Data to 2022f #10940

Closed
wants to merge 1 commit into from

Conversation

satoyoshiki
Copy link

@satoyoshiki satoyoshiki commented Nov 2, 2022

Please review this PR. The PR includes changes in the resource bundle sources to follow the time zone change observed in America/Chihuahua and America/Ojinaga.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10940/head:pull/10940
$ git checkout pull/10940

Update a local copy of the PR:
$ git checkout pull/10940
$ git pull https://git.openjdk.org/jdk pull/10940/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10940

View PR using the GUI difftool:
$ git pr show -t 10940

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10940.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 2, 2022

👋 Welcome back ysatowse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 2, 2022

@satoyoshiki The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@satoyoshiki
Copy link
Author

/issue JDK-8296108

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Nov 2, 2022
@openjdk openjdk bot changed the title 1st commit for tz2022f 8296108: (tz) Update Timezone Data to 2022f Nov 2, 2022
@openjdk
Copy link

openjdk bot commented Nov 2, 2022

@satoyoshiki The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 2, 2022
@satoyoshiki
Copy link
Author

@naotoj Can I ask you to review the PR?

@mlbridge
Copy link

mlbridge bot commented Nov 2, 2022

Webrevs

Copy link
Member

@mrserb mrserb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@openjdk
Copy link

openjdk bot commented Nov 2, 2022

@satoyoshiki This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296108: (tz) Update Timezone Data to 2022f

Reviewed-by: serb, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 58 new commits pushed to the master branch:

  • 0349803: 8295319: pending_cards_at_gc_start doesn't include cards in thread buffers
  • 8f6c048: 8296337: CDS SharedArchiveConsistency tests fail after JDK-8296157
  • a8070fb: 8296157: Rename FileMapInfo::space_at() to region_at()
  • f43bb9f: 8296190: TestMD5Intrinsics and TestMD5MultiBlockIntrinsics don't test the intrinsics
  • b685fc2: 8295685: Update Libpng to 1.6.38
  • 94eb25a: 8256072: Eliminate JVMTI tagmap rehashing
  • 4338f52: 8294241: Deprecate URL public constructors
  • 68209ad: 8288232: Address typos in jar man page
  • 2ff9d3a: 8294858: XMLStreamReader does not respect jdk.xml.maxXMLNameLimit=0 for namespace names
  • 72f74df: 8292427: Improve specification of InflaterInputStream.fill()
  • ... and 48 more: https://git.openjdk.org/jdk/compare/2e7163759c75cab6ab5ffa04c13d32ccc95f9719...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb, @naotoj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 2, 2022
Copy link
Member

@naotoj naotoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoyoshiki
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 4, 2022
@openjdk
Copy link

openjdk bot commented Nov 4, 2022

@satoyoshiki
Your change (at version 9a299f9) is now ready to be sponsored by a Committer.

@naotoj
Copy link
Member

naotoj commented Nov 4, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 4, 2022

Going to push as commit 9d3b4ef.
Since your change was applied there have been 59 commits pushed to the master branch:

  • 4d1bc1b: 8296285: test/hotspot/jtreg/compiler/intrinsics/TestFloatIsFinite.java fails after JDK-8280378
  • 0349803: 8295319: pending_cards_at_gc_start doesn't include cards in thread buffers
  • 8f6c048: 8296337: CDS SharedArchiveConsistency tests fail after JDK-8296157
  • a8070fb: 8296157: Rename FileMapInfo::space_at() to region_at()
  • f43bb9f: 8296190: TestMD5Intrinsics and TestMD5MultiBlockIntrinsics don't test the intrinsics
  • b685fc2: 8295685: Update Libpng to 1.6.38
  • 94eb25a: 8256072: Eliminate JVMTI tagmap rehashing
  • 4338f52: 8294241: Deprecate URL public constructors
  • 68209ad: 8288232: Address typos in jar man page
  • 2ff9d3a: 8294858: XMLStreamReader does not respect jdk.xml.maxXMLNameLimit=0 for namespace names
  • ... and 49 more: https://git.openjdk.org/jdk/compare/2e7163759c75cab6ab5ffa04c13d32ccc95f9719...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 4, 2022
@openjdk openjdk bot closed this Nov 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 4, 2022
@openjdk
Copy link

openjdk bot commented Nov 4, 2022

@naotoj @satoyoshiki Pushed as commit 9d3b4ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
3 participants