Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296168: x86: Add reasonable constraints between AVX and SSE #10946

Closed
wants to merge 3 commits into from

Conversation

cl4es
Copy link
Member

@cl4es cl4es commented Nov 2, 2022

We've not seen any x86 CPU, Intel or otherwise, where AVX features are available but SSE 4.1 is not supported. This patch suggests constraining setup so that any explicit value of UseSSE less than 4 (the default on any AVX-supporting CPU) implicitly disables AVX. This simplifies ergonomics and reduces the testing surface. Concretely this would allow #10847 to not have to guard the new intrinsic on UseSSE level to avoid some surprising test failures in tests verifying SSE-enabled intrinsics.

I've rearranged the initialization of UseAVX and UseSSE to allow AVX to look at the post-ergo values of UseSSE.

Testing: tier1-tier3, manual verification


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296168: x86: Add reasonable constraints between AVX and SSE

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10946/head:pull/10946
$ git checkout pull/10946

Update a local copy of the PR:
$ git checkout pull/10946
$ git pull https://git.openjdk.org/jdk pull/10946/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10946

View PR using the GUI difftool:
$ git pr show -t 10946

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10946.diff

@cl4es
Copy link
Member Author

cl4es commented Nov 2, 2022

/label add hotspot-compiler

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 2, 2022

👋 Welcome back redestad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review hotspot-compiler hotspot-compiler-dev@openjdk.org labels Nov 2, 2022
@openjdk
Copy link

openjdk bot commented Nov 2, 2022

@cl4es
The hotspot-compiler label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Nov 2, 2022

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

src/hotspot/cpu/x86/vm_version_x86.cpp Outdated Show resolved Hide resolved
@openjdk
Copy link

openjdk bot commented Nov 2, 2022

@cl4es This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296168: x86: Add reasonable constraints between AVX and SSE

Reviewed-by: kvn, vlivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

  • fd60036: 8296188: Update style and header in JDWP Protocol spec and JVMTI spec
  • c7b95a8: 8296163: [aarch64] Cleanup Pre/Post addressing mode classes
  • f84b0ad: 8295670: Remove duplication in java/util/Formatter/Basic*.java
  • a124d8e: 8296115: Allow for compiling the JDK with strict standards conformance
  • 491d43c: 8289838: ZGC: OOM before clearing all SoftReferences
  • a1c349f: 8290063: IGV: Give the graphs a unique number in the outline
  • b807470: 8296235: IGV: Change shortcut to delete graph from ctrl+del to del
  • e15d241: 8295991: java/net/httpclient/CancelRequestTest.java fails intermittently
  • 16a041a: 8296142: CertAttrSet::(getName|getElements|delete) are mostly useless
  • 6626a29: 8294845: Make globals accessed by G1 young gen revising atomic
  • ... and 15 more: https://git.openjdk.org/jdk/compare/0d0bd7bd409c0caa5edebe3d1eacf8e5bb48f984...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 2, 2022
src/hotspot/cpu/x86/vm_version_x86.cpp Outdated Show resolved Hide resolved
src/hotspot/cpu/x86/vm_version_x86.cpp Outdated Show resolved Hide resolved
src/hotspot/cpu/x86/vm_version_x86.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

Copy link

@iwanowww iwanowww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@cl4es
Copy link
Member Author

cl4es commented Nov 3, 2022

Thanks for reviewing!

/integrate

@openjdk
Copy link

openjdk bot commented Nov 3, 2022

Going to push as commit 6ee8ccf.
Since your change was applied there have been 27 commits pushed to the master branch:

  • 1950747: 8279913: obsolete ExtendedDTraceProbes
  • 13b20e0: 8296262: Remove dead code from InstanceKlass::signature_name()
  • fd60036: 8296188: Update style and header in JDWP Protocol spec and JVMTI spec
  • c7b95a8: 8296163: [aarch64] Cleanup Pre/Post addressing mode classes
  • f84b0ad: 8295670: Remove duplication in java/util/Formatter/Basic*.java
  • a124d8e: 8296115: Allow for compiling the JDK with strict standards conformance
  • 491d43c: 8289838: ZGC: OOM before clearing all SoftReferences
  • a1c349f: 8290063: IGV: Give the graphs a unique number in the outline
  • b807470: 8296235: IGV: Change shortcut to delete graph from ctrl+del to del
  • e15d241: 8295991: java/net/httpclient/CancelRequestTest.java fails intermittently
  • ... and 17 more: https://git.openjdk.org/jdk/compare/0d0bd7bd409c0caa5edebe3d1eacf8e5bb48f984...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 3, 2022
@openjdk openjdk bot closed this Nov 3, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 3, 2022
@openjdk
Copy link

openjdk bot commented Nov 3, 2022

@cl4es Pushed as commit 6ee8ccf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants