Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8288232: Address typos in jar man page #10947

Closed
wants to merge 3 commits into from

Conversation

LanceAndersen
Copy link
Contributor

@LanceAndersen LanceAndersen commented Nov 2, 2022

Hi

Please review this update to the jar man page which removes the "=" for the non GNU style options

Best
Lance


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10947/head:pull/10947
$ git checkout pull/10947

Update a local copy of the PR:
$ git checkout pull/10947
$ git pull https://git.openjdk.org/jdk pull/10947/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10947

View PR using the GUI difftool:
$ git pr show -t 10947

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10947.diff

@LanceAndersen LanceAndersen marked this pull request as ready for review November 2, 2022 14:04
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 2, 2022

👋 Welcome back lancea! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 2, 2022
@openjdk
Copy link

openjdk bot commented Nov 2, 2022

@LanceAndersen The following labels will be automatically applied to this pull request:

  • compiler
  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org compiler compiler-dev@openjdk.org labels Nov 2, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 2, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 2, 2022

@LanceAndersen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288232: Address typos in jar man page

Reviewed-by: joehw, naoto, bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 435 new commits pushed to the master branch:

  • c7b95a8: 8296163: [aarch64] Cleanup Pre/Post addressing mode classes
  • f84b0ad: 8295670: Remove duplication in java/util/Formatter/Basic*.java
  • a124d8e: 8296115: Allow for compiling the JDK with strict standards conformance
  • 491d43c: 8289838: ZGC: OOM before clearing all SoftReferences
  • a1c349f: 8290063: IGV: Give the graphs a unique number in the outline
  • b807470: 8296235: IGV: Change shortcut to delete graph from ctrl+del to del
  • e15d241: 8295991: java/net/httpclient/CancelRequestTest.java fails intermittently
  • 16a041a: 8296142: CertAttrSet::(getName|getElements|delete) are mostly useless
  • 6626a29: 8294845: Make globals accessed by G1 young gen revising atomic
  • dac6ecc: 8295990: Improve make handling of strip flags
  • ... and 425 more: https://git.openjdk.org/jdk/compare/887319243351c198152f49ead3e4790442c52d95...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 2, 2022
@LanceAndersen
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 3, 2022

Going to push as commit 68209ad.
Since your change was applied there have been 449 commits pushed to the master branch:

  • 2ff9d3a: 8294858: XMLStreamReader does not respect jdk.xml.maxXMLNameLimit=0 for namespace names
  • 72f74df: 8292427: Improve specification of InflaterInputStream.fill()
  • 53905e6: 8178355: IdentityHashMap uses identity-based comparison for values everywhere except remove(K,V) and replace(K,V,V)
  • 25dfcbd: 8289689: (fs) Re-examine the need for normalization to Unicode Normalization Format D (macOS)
  • b7442d1: 8295653: Add a graph of the sealed class hierarchy for marked classes
  • 59a13b1: 8295872: [PPC64] JfrGetCallTrace: Need pc == nullptr check before frame constructor
  • 2a79dfc: 8295774: Write a test to verify List sends ItemEvent/ActionEvent
  • cc3c5a1: 8296101: nmethod::is_unloading result unstable with concurrent unloading
  • d771abb: 8295970: Add vector api sanity tests in tier1
  • 7a85441: 8232933: Javac inferred type does not conform to equality constraint
  • ... and 439 more: https://git.openjdk.org/jdk/compare/887319243351c198152f49ead3e4790442c52d95...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 3, 2022
@openjdk openjdk bot closed this Nov 3, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 3, 2022
@openjdk
Copy link

openjdk bot commented Nov 3, 2022

@LanceAndersen Pushed as commit 68209ad.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants