Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8295685: Update Libpng to 1.6.38 #10953

Closed
wants to merge 6 commits into from

Conversation

honkar-jdk
Copy link
Contributor

@honkar-jdk honkar-jdk commented Nov 2, 2022

Updated libpng library to v1.6.38.

Following files have been updated -

  • 12 source code files of libpng
  • LICENSE, README, CHANGES, UPDATING text files
  • legal/libpng.md

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10953/head:pull/10953
$ git checkout pull/10953

Update a local copy of the PR:
$ git checkout pull/10953
$ git pull https://git.openjdk.org/jdk pull/10953/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10953

View PR using the GUI difftool:
$ git pr show -t 10953

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10953.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 2, 2022

👋 Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 2, 2022

@honkar-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Nov 2, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 2, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 2, 2022

Webrevs

Copy link
Contributor

@prrace prrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine on the understanding that you built + tested on all platforms - running all automated tests.

@openjdk
Copy link

openjdk bot commented Nov 3, 2022

@honkar-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295685: Update Libpng to 1.6.38

Reviewed-by: prr, azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

  • 25dfcbd: 8289689: (fs) Re-examine the need for normalization to Unicode Normalization Format D (macOS)
  • b7442d1: 8295653: Add a graph of the sealed class hierarchy for marked classes
  • 59a13b1: 8295872: [PPC64] JfrGetCallTrace: Need pc == nullptr check before frame constructor
  • 2a79dfc: 8295774: Write a test to verify List sends ItemEvent/ActionEvent
  • cc3c5a1: 8296101: nmethod::is_unloading result unstable with concurrent unloading
  • d771abb: 8295970: Add vector api sanity tests in tier1
  • 7a85441: 8232933: Javac inferred type does not conform to equality constraint
  • 6ee8ccf: 8296168: x86: Add reasonable constraints between AVX and SSE
  • 1950747: 8279913: obsolete ExtendedDTraceProbes
  • 13b20e0: 8296262: Remove dead code from InstanceKlass::signature_name()
  • ... and 29 more: https://git.openjdk.org/jdk/compare/590de37bd703bdae56e8b41c84f5fca5e5a00811...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace, @azvegint) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 3, 2022
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated labels Nov 3, 2022
@honkar-jdk
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 3, 2022
@openjdk
Copy link

openjdk bot commented Nov 3, 2022

@honkar-jdk
Your change (at version 3dc49a5) is now ready to be sponsored by a Committer.

@prrace
Copy link
Contributor

prrace commented Nov 3, 2022

/integrate

@prrace
Copy link
Contributor

prrace commented Nov 3, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 3, 2022

@prrace Only the author (@honkar-jdk) is allowed to issue the integrate command. As this pull request is ready to be sponsored, and you are an eligible sponsor, did you mean to issue the /sponsor command?

@openjdk
Copy link

openjdk bot commented Nov 3, 2022

Going to push as commit b685fc2.
Since your change was applied there have been 45 commits pushed to the master branch:

  • 94eb25a: 8256072: Eliminate JVMTI tagmap rehashing
  • 4338f52: 8294241: Deprecate URL public constructors
  • 68209ad: 8288232: Address typos in jar man page
  • 2ff9d3a: 8294858: XMLStreamReader does not respect jdk.xml.maxXMLNameLimit=0 for namespace names
  • 72f74df: 8292427: Improve specification of InflaterInputStream.fill()
  • 53905e6: 8178355: IdentityHashMap uses identity-based comparison for values everywhere except remove(K,V) and replace(K,V,V)
  • 25dfcbd: 8289689: (fs) Re-examine the need for normalization to Unicode Normalization Format D (macOS)
  • b7442d1: 8295653: Add a graph of the sealed class hierarchy for marked classes
  • 59a13b1: 8295872: [PPC64] JfrGetCallTrace: Need pc == nullptr check before frame constructor
  • 2a79dfc: 8295774: Write a test to verify List sends ItemEvent/ActionEvent
  • ... and 35 more: https://git.openjdk.org/jdk/compare/590de37bd703bdae56e8b41c84f5fca5e5a00811...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 3, 2022
@openjdk openjdk bot closed this Nov 3, 2022
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Nov 3, 2022
@openjdk openjdk bot removed rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 3, 2022
@openjdk
Copy link

openjdk bot commented Nov 3, 2022

@prrace @honkar-jdk Pushed as commit b685fc2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants