Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296285: test/hotspot/jtreg/compiler/intrinsics/TestFloatIsFinite.java fails after JDK-8280378 #10965

Closed
wants to merge 1 commit into from

Conversation

RealFYang
Copy link
Member

@RealFYang RealFYang commented Nov 3, 2022

Hi,
Please review this trivial change fixing a typo in jtreg test: test/hotspot/jtreg/compiler/intrinsics/TestFloatIsFinite.java
This typo is introduced by JDK-8280378 and the test case fails to compile by javac when running on RISC-V.
Testing: Test case passed on RISC-V after this typo is fixed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296285: test/hotspot/jtreg/compiler/intrinsics/TestFloatIsFinite.java fails after JDK-8280378

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10965/head:pull/10965
$ git checkout pull/10965

Update a local copy of the PR:
$ git checkout pull/10965
$ git pull https://git.openjdk.org/jdk pull/10965/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10965

View PR using the GUI difftool:
$ git pr show -t 10965

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10965.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 3, 2022

👋 Welcome back fyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 3, 2022
@openjdk
Copy link

openjdk bot commented Nov 3, 2022

@RealFYang The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Nov 3, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 3, 2022

Webrevs

Copy link
Member

@DamonFool DamonFool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and trivial.

@openjdk
Copy link

openjdk bot commented Nov 3, 2022

@RealFYang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296285: test/hotspot/jtreg/compiler/intrinsics/TestFloatIsFinite.java fails after JDK-8280378

Reviewed-by: jiefu, thartmann, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • cc3c5a1: 8296101: nmethod::is_unloading result unstable with concurrent unloading
  • d771abb: 8295970: Add vector api sanity tests in tier1
  • 7a85441: 8232933: Javac inferred type does not conform to equality constraint
  • 6ee8ccf: 8296168: x86: Add reasonable constraints between AVX and SSE
  • 1950747: 8279913: obsolete ExtendedDTraceProbes
  • 13b20e0: 8296262: Remove dead code from InstanceKlass::signature_name()

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 3, 2022
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! I missed that typo as I could not run this test on RISC-V.

@RealFYang
Copy link
Member Author

Thank you!
/integrate

@openjdk
Copy link

openjdk bot commented Nov 4, 2022

Going to push as commit 4d1bc1b.
Since your change was applied there have been 21 commits pushed to the master branch:

  • 0349803: 8295319: pending_cards_at_gc_start doesn't include cards in thread buffers
  • 8f6c048: 8296337: CDS SharedArchiveConsistency tests fail after JDK-8296157
  • a8070fb: 8296157: Rename FileMapInfo::space_at() to region_at()
  • f43bb9f: 8296190: TestMD5Intrinsics and TestMD5MultiBlockIntrinsics don't test the intrinsics
  • b685fc2: 8295685: Update Libpng to 1.6.38
  • 94eb25a: 8256072: Eliminate JVMTI tagmap rehashing
  • 4338f52: 8294241: Deprecate URL public constructors
  • 68209ad: 8288232: Address typos in jar man page
  • 2ff9d3a: 8294858: XMLStreamReader does not respect jdk.xml.maxXMLNameLimit=0 for namespace names
  • 72f74df: 8292427: Improve specification of InflaterInputStream.fill()
  • ... and 11 more: https://git.openjdk.org/jdk/compare/fd60036a34b0a8516eb29b698674c8242c4a84c1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 4, 2022
@openjdk openjdk bot closed this Nov 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 4, 2022
@openjdk
Copy link

openjdk bot commented Nov 4, 2022

@RealFYang Pushed as commit 4d1bc1b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealFYang RealFYang deleted the JDK-8296285 branch November 4, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
4 participants